From owner-freebsd-rc@FreeBSD.ORG Wed Nov 30 18:53:25 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C76CE106566C; Wed, 30 Nov 2011 18:53:25 +0000 (UTC) (envelope-from cvs-src@yandex.ru) Received: from forward5.mail.yandex.net (forward5.mail.yandex.net [IPv6:2a02:6b8:0:602::5]) by mx1.freebsd.org (Postfix) with ESMTP id 418A98FC18; Wed, 30 Nov 2011 18:53:25 +0000 (UTC) Received: from smtp2.mail.yandex.net (smtp2.mail.yandex.net [77.88.46.102]) by forward5.mail.yandex.net (Yandex) with ESMTP id 987C212021C8; Wed, 30 Nov 2011 22:53:23 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1322679203; bh=f7qL/TV+j4iECgXTCynu4eJ3G55zu7WeQDzpwCyb7Pw=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=WGUUs6gQxqeAk6cfvRGREt3A5S98lbwPwZO/VcAI4GWV+GJc3hjVDH9pRG2sMUQqx gJXRMy/EZ/UhsFj3dt/5rKXCVEyECRQW0Gc7HPMz3ap8TyyEsRXKjxvlohGLQj0X27 H9CbbIWgRIyXEHtSBOkUP3w0xDSkk7ZuEdk6i4Kk= Received: from smtp2.mail.yandex.net (localhost [127.0.0.1]) by smtp2.mail.yandex.net (Yandex) with ESMTP id EBC5BE20347; Wed, 30 Nov 2011 22:53:22 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1322679203; bh=f7qL/TV+j4iECgXTCynu4eJ3G55zu7WeQDzpwCyb7Pw=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=WGUUs6gQxqeAk6cfvRGREt3A5S98lbwPwZO/VcAI4GWV+GJc3hjVDH9pRG2sMUQqx gJXRMy/EZ/UhsFj3dt/5rKXCVEyECRQW0Gc7HPMz3ap8TyyEsRXKjxvlohGLQj0X27 H9CbbIWgRIyXEHtSBOkUP3w0xDSkk7ZuEdk6i4Kk= Received: from unknown (unknown [213.138.88.133]) by smtp2.mail.yandex.net (nwsmtp/Yandex) with ESMTP id rMw00QFp-rMwawg2a; Wed, 30 Nov 2011 22:53:22 +0400 X-Yandex-Spam: 1 Message-ID: <4ED67B8F.50109@yandex.ru> Date: Wed, 30 Nov 2011 22:53:03 +0400 From: Ruslan Mahmatkhanov User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:8.0) Gecko/20111109 Thunderbird/8.0 MIME-Version: 1.0 To: Chris Rees References: <4ED66DCB.1040102@yandex.ru> In-Reply-To: X-Enigmail-Version: undefined Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@freebsd.org Subject: Re: rc-script review request X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2011 18:53:25 -0000 Chris Rees wrote on 30.11.2011 22:15: > On 30 November 2011 17:54, Ruslan Mahmatkhanov wrote: >> Hello. >> >> I'm planning to finish repocopy of www/zope213 this evening. Would you >> please review rc-script that is supplied with it [1]? >> >> I get this one from www/zope211 and minimally changed it, and as far i >> can tell dougb@ was the last person who touched it, so it should be ok, >> but i'm asking for review just for the case. >> >> I'm attached the script in question and provide the link to it for the >> case if mailmain will eat it. >> >> Thank you much in advance. > > I could get yelled at for this, but normally I'd prefer: Please yell, i'm not experienced in rc at all, so i'll be glad any guidance (in any form) to raise it (experience) :). But i thought that it's safe to use existing scripts from the tree. > start_cmd="${name}_start" > > over > > start_cmd="zope213_start". > > Chris Fixed, thank you. I also added `KEYWORD: shutdown' per PH, because of zope starting under non-root user. Is there still any problems in the script? Updated version here: https://github.com/mexicarne/zope/blob/master/www/zope213/files/zope213.in -- Regards, Ruslan Tinderboxing kills... the drives.