From owner-svn-ports-all@freebsd.org  Fri Jun 21 21:27:50 2019
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3671E15BFA86;
 Fri, 21 Jun 2019 21:27:50 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id D09BA817AF;
 Fri, 21 Jun 2019 21:27:49 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id C05E11BE2C; Fri, 21 Jun 2019 21:27:49 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Mark Linimon <linimon@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r504811 - head/net/tcpkali
References: <201906212006.x5LK6ITT066843@repo.freebsd.org>
Date: Fri, 21 Jun 2019 23:27:41 +0200
In-Reply-To: <201906212006.x5LK6ITT066843@repo.freebsd.org> (Mark Linimon's
 message of "Fri, 21 Jun 2019 20:06:18 +0000 (UTC)")
Message-ID: <d0j6-pr1u-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-Rspamd-Queue-Id: D09BA817AF
X-Spamd-Bar: --
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-2.93 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 NEURAL_HAM_MEDIUM(-1.00)[-0.996,0];
 NEURAL_HAM_LONG(-1.00)[-1.000,0];
 NEURAL_HAM_SHORT(-0.93)[-0.932,0];
 ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Jun 2019 21:27:50 -0000

Mark Linimon <linimon@FreeBSD.org> writes:

> -.include <bsd.port.mk>
> +.include <bsd.port.pre.mk>
> +
> +.if ${CHOSEN_COMPILER_TYPE} == gcc
> +BROKEN=		src/tcpkali_atomic.h unconditionally includes x86 assembler
> +.endif

lang/gcc8 on powerpc64 does support __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4,
so maybe try USES=compiler:c11 instead. GCC 4.2 on amd64 does define
__GCC_HAVE_SYNC_COMPARE_AND_SWAP_4 but not __SIZEOF_SIZE_T__. As the
assembly fallback uses SIZEOF_SIZE_T (without underscores) it wouldn't
compile even on x86 e.g.,

In file included from tcpkali_traffic_stats.h:30,
                 from tcpkali_engine.h:33,
                 from tcpkali.h:31,
                 from tcpkali_dns.c:42:
tcpkali_atomic.h:101: error: expected specifier-qualifier-list before 'non_atomic_wide_t'
tcpkali_atomic.h:102: error: expected specifier-qualifier-list before 'non_atomic_narrow_t'
In file included from tcpkali_traffic_stats.h:30,
                 from tcpkali_engine.h:33,
                 from tcpkali.h:31,
                 from tcpkali_dns.c:42:
tcpkali_atomic.h:111:2: error: #error "Weird platform, aborting"

--
In short, the BROKEN message is garbage.