From owner-svn-src-head@freebsd.org Mon Jan 4 23:49:20 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 86E0FA62E08 for ; Mon, 4 Jan 2016 23:49:20 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qg0-x22f.google.com (mail-qg0-x22f.google.com [IPv6:2607:f8b0:400d:c04::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3EE5E1580 for ; Mon, 4 Jan 2016 23:49:20 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qg0-x22f.google.com with SMTP id b35so136987374qge.0 for ; Mon, 04 Jan 2016 15:49:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=IlOSlfinkiemEf2IasfuFXgbT4P5YC0pF1GSOIuTUMM=; b=HwpuXVxtjcjhuwZwOR//Ipzykg/CmOSbJnwE28JIRmTW2Xoi6Ed7uXB0G/eRoO/TW6 +a6IL6ezGBiQqbxXxzO79ESGq73QUs2bsJImRBCb/wiIHW8nPYIiDZRfPBLf10rl4cK7 CL8iXghOeGObycHJWF/ArN5qeYhzBIf5UOLUSskglWYmF1LPdeY+7DruY/MNoC+fzbNx sxMaBF0Ok0uQf2F+XmLEAzm1v8Jf0VJWjk/j5lNsmLltJvxX3ZpUyCEAoAsPSTfibfHe GCSqbJTTXWsglNUBBk1wEIGdGsX8AjoZ8d1yQpay1SOU3qiFVz+DkTVRv4qV7UO+YPo8 jpIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=IlOSlfinkiemEf2IasfuFXgbT4P5YC0pF1GSOIuTUMM=; b=Y3J1tQVm6/1mqjaZjVGBhWjVHgG41gJgxYbuX3GXDF0dHnuRjzb1q0AqI6lpcbgMuk 7aGB4DNQaJMGTDL8ee2MZ6p2xP/74YTXGi9vuTL/Kv1P30VuR4BMCXKIkNPXUnns3Wvh XjVU60BV6hTh1SMqXap/DVbBtHPLFN80VYp8Auzk16lln6Ugk6nSm6wn33vTBPWNCINv jUAJPHL0ooTDIcwl3Hb+6YTHu8PrE5VyRWCa7gjFWtnTbAAzzDoap/mxIapMiZC+LLXs uyvOMFI0BezBO2HL5k3CIPOMHZSb4p1FLroO+9Muyp+lJ2ZSJN/hRuwdMz0bM2cqngTr nKzg== X-Gm-Message-State: ALoCoQn066/sgmey9aGEKwX8/Hd55nSINU7w6GTmOdK3f5TNPRB0Zd57dmwZXMoM6aA8zq1aoiP1yR+RrV/bN6E7hdwqgpGlDQ== MIME-Version: 1.0 X-Received: by 10.140.29.131 with SMTP id b3mr117291688qgb.50.1451951359360; Mon, 04 Jan 2016 15:49:19 -0800 (PST) Sender: wlosh@bsdimp.com Received: by 10.140.27.181 with HTTP; Mon, 4 Jan 2016 15:49:19 -0800 (PST) X-Originating-IP: [2601:280:4900:3700:a51c:df79:65a:a353] In-Reply-To: <1777356.pH0Cpe84Od@ralph.baldwin.cx> References: <201512191901.tBJJ1hEP013786@repo.freebsd.org> <1777356.pH0Cpe84Od@ralph.baldwin.cx> Date: Mon, 4 Jan 2016 16:49:19 -0700 X-Google-Sender-Auth: 89I1P63UPnRdn7SxxwrVH5obVKY Message-ID: Subject: Re: svn commit: r292472 - in head/sys: amd64/amd64 sys From: Warner Losh To: John Baldwin Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jan 2016 23:49:20 -0000 On Mon, Dec 21, 2015 at 1:38 PM, John Baldwin wrote: > On Saturday, December 19, 2015 07:01:43 PM Warner Losh wrote: > > Author: imp > > Date: Sat Dec 19 19:01:43 2015 > > New Revision: 292472 > > URL: https://svnweb.freebsd.org/changeset/base/292472 > > > > Log: > > Save the physical address passed into the kernel of the UEFI system > > table. > > > > Modified: > > head/sys/amd64/amd64/machdep.c > > head/sys/sys/efi.h > > > > Modified: head/sys/amd64/amd64/machdep.c > > > ============================================================================== > > --- head/sys/amd64/amd64/machdep.c Sat Dec 19 19:01:42 2015 > (r292471) > > +++ head/sys/amd64/amd64/machdep.c Sat Dec 19 19:01:43 2015 > (r292472) > > @@ -1615,6 +1622,8 @@ hammer_time(u_int64_t modulep, u_int64_t > > /* > > * Use vt(4) by default for UEFI boot (during the sc(4)/vt(4) > > * transition). > > + * Once bootblocks have updated, we can test directly for > > + * efi_systbl != NULL here... > > */ > > if (preload_search_info(kmdp, MODINFO_METADATA | MODINFOMD_EFI_MAP) > > != NULL) > > This part doesn't seem worth changing since the EFI map is always going to > be > there and works for both old and new loaders? > Just a simpler test. This code suffers from too much complexity, but maybe compat will keep us from doing this for a long time. Warner