From nobody Wed Mar 1 15:01:30 2023 X-Original-To: freebsd-git@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PRcrl4kFkz3txXZ for ; Wed, 1 Mar 2023 15:01:43 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PRcrl0D4pz3Mtt; Wed, 1 Mar 2023 15:01:43 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-f43.google.com with SMTP id s20so17964805lfb.11; Wed, 01 Mar 2023 07:01:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677682900; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jhY1oVTMxkEGaGHmTVpiAOuNP6I0aREZm3zC08O9vwE=; b=ol/4EkfMw4AuTphnpfuZoWz5xJ4SAOXvdtroZALhPqMR70LbZaCQUtXzGtQl+HRpoG JlTnzBHiKzUnUtejUGjnVuocn3PNy6MS19+SSubVF+e9wikCSy2zQscYWRBGECyqz11p 8d3xnTcFXFO+vc03PuoPqEpd4n8u8vbHDkSG76XXHjgz26FA6VFyhBO2TyP2Pi2kYbaR qZ1rt4XtUCRSvWQ9BgGFtA5l1sAOxHKXKOfJjwdeK39bBCI1odoaR4iIPiCCX9OY1MND yJdocwv3XDmq9v+hk3RU6nZk3RzW+xB22rdIE6sL/iyN6GpZZu2KQ8jd45tXsaqEGl6M ll5Q== X-Gm-Message-State: AO0yUKXWog88nV8GQvjRbQx1xeUI+tv5coXIYXv9M7dYEhs0wnDSU2cz UK5MqV+RnYwzAbPgwpO4ObUltSTL3WhMI/MnTxBlCgpVVHk= X-Google-Smtp-Source: AK7set9MhQ8wT0AVXs4mG3hMRY6fB4ggh5n+ReIbgt2XIPPVSDnELoU78iHm+33/TGhJQuoMWDgA8JynWeCRuJCheOI= X-Received: by 2002:ac2:5388:0:b0:4db:257b:f605 with SMTP id g8-20020ac25388000000b004db257bf605mr1943848lfh.2.1677682900167; Wed, 01 Mar 2023 07:01:40 -0800 (PST) List-Id: Discussion of git use in the FreeBSD project List-Archive: https://lists.freebsd.org/archives/freebsd-git List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-git@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Ed Maste Date: Wed, 1 Mar 2023 10:01:30 -0500 Message-ID: Subject: Re: Report on the pull request experiment so far To: Brooks Davis Cc: Warner Losh , freebsd-git Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4PRcrl0D4pz3Mtt X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Tue, 28 Feb 2023 at 18:04, Brooks Davis wrote: > > IMO we should enforce this on commit dates regardless[0]. There is no > conceivable value in allowing people to commit from systems with wildly > wrong clocks given they must be on the internet to commit. Yes, I think it a reasonable commit hook could enforce having the commit date be: - later than the first parent - earlier than the server's current time On Tue, 28 Feb 2023 at 20:48, Warner Losh wrote: > > A bigger issue in my mind is the project's use of trailer metadata that doesn't match what git expects. The whole spaces vs - thing is making tooling harder than it needs to be... The open source world has standardized on dashes, so we might as well follow suit and change the committer's guide and template to have "Sponsored-by" etc. "Differential Revision" might be an issue, but if "Differential-revision:" is not currently accepted by Phabricator we ought to just patch it.