Date: Wed, 1 Mar 2023 10:01:30 -0500 From: Ed Maste <emaste@freebsd.org> To: Brooks Davis <brooks@freebsd.org> Cc: Warner Losh <imp@bsdimp.com>, freebsd-git <freebsd-git@freebsd.org> Subject: Re: Report on the pull request experiment so far Message-ID: <CAPyFy2CgXh4rgTYJQE70w3eF6N2gA0VcFCpdgocsYoZj-AROuw@mail.gmail.com> In-Reply-To: <Y/6IkCD%2B5YawlCHX@spindle.one-eyed-alien.net> References: <CANCZdfoOm3iWZHvh6oy4Cj6qpcvnHjAWpbvNp7r9msfwO_r5fg@mail.gmail.com> <CAPyFy2D7MBsThAUYkVyh1Tg3UW8mAvBXL5wwmSKjpSsHFm5y1Q@mail.gmail.com> <Y/6IkCD%2B5YawlCHX@spindle.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 28 Feb 2023 at 18:04, Brooks Davis <brooks@freebsd.org> wrote: > > IMO we should enforce this on commit dates regardless[0]. There is no > conceivable value in allowing people to commit from systems with wildly > wrong clocks given they must be on the internet to commit. Yes, I think it a reasonable commit hook could enforce having the commit date be: - later than the first parent - earlier than the server's current time On Tue, 28 Feb 2023 at 20:48, Warner Losh <imp@bsdimp.com> wrote: > > A bigger issue in my mind is the project's use of trailer metadata that doesn't match what git expects. The whole spaces vs - thing is making tooling harder than it needs to be... The open source world has standardized on dashes, so we might as well follow suit and change the committer's guide and template to have "Sponsored-by" etc. "Differential Revision" might be an issue, but if "Differential-revision:" is not currently accepted by Phabricator we ought to just patch it.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2CgXh4rgTYJQE70w3eF6N2gA0VcFCpdgocsYoZj-AROuw>