From owner-freebsd-bugs@FreeBSD.ORG Sun May 12 18:40:01 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id C203A34E for ; Sun, 12 May 2013 18:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 8ECD7917 for ; Sun, 12 May 2013 18:40:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r4CIe1B1063434 for ; Sun, 12 May 2013 18:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r4CIe1qS063433; Sun, 12 May 2013 18:40:01 GMT (envelope-from gnats) Resent-Date: Sun, 12 May 2013 18:40:01 GMT Resent-Message-Id: <201305121840.r4CIe1qS063433@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Trond Endrestol Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id F3880340 for ; Sun, 12 May 2013 18:39:09 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.FreeBSD.org (oldred.freebsd.org [8.8.178.121]) by mx1.freebsd.org (Postfix) with ESMTP id E5D8D90E for ; Sun, 12 May 2013 18:39:09 +0000 (UTC) Received: from oldred.FreeBSD.org ([127.0.1.6]) by oldred.FreeBSD.org (8.14.5/8.14.5) with ESMTP id r4CId7JR002434 for ; Sun, 12 May 2013 18:39:07 GMT (envelope-from nobody@oldred.FreeBSD.org) Received: (from nobody@localhost) by oldred.FreeBSD.org (8.14.5/8.14.5/Submit) id r4CId7Z2002433; Sun, 12 May 2013 18:39:07 GMT (envelope-from nobody) Message-Id: <201305121839.r4CId7Z2002433@oldred.FreeBSD.org> Date: Sun, 12 May 2013 18:39:07 GMT From: Trond Endrestol To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: kern/178540: kern.geom.confdot contains superfluous semicolon at the end of the last curly brace X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 May 2013 18:40:01 -0000 >Number: 178540 >Category: kern >Synopsis: kern.geom.confdot contains superfluous semicolon at the end of the last curly brace >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun May 12 18:40:01 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Trond Endrestol >Release: 10.0-CURRENT >Organization: Private >Environment: FreeBSD freebsd10.bsd.net 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r250558: Sun May 12 14:32:16 CEST 2013 root@freebsd10.bsd.net:/usr/obj/usr/src/sys/VBOX amd64 >Description: The sysctl kern.geom.confdot contains a superfluous semicolon after the last curly brace, making the dot utility from graphics/graphviz complain like this: Warning: :1: syntax error in line 1 near ';' >How-To-Repeat: Install graphics/graphviz and run: sysctl -n kern.geom.confdot | dot -Tps > geom.ps >Fix: Remove the offending semicolon from sys/geom/geom_dump.c: --- geom_dump.c.orig 2013-04-26 17:16:50.000000000 +0200 +++ geom_dump.c 2013-05-12 20:28:40.369226016 +0200 @@ -105,7 +105,7 @@ sbuf_printf(sb, "digraph geom {\n"); LIST_FOREACH(mp, &g_classes, class) g_confdot_class(sb, mp); - sbuf_printf(sb, "};\n"); + sbuf_printf(sb, "}\n"); sbuf_finish(sb); } Patch attached with submission follows: --- geom_dump.c.orig 2013-04-26 17:16:50.000000000 +0200 +++ geom_dump.c 2013-05-12 20:28:40.369226016 +0200 @@ -105,7 +105,7 @@ sbuf_printf(sb, "digraph geom {\n"); LIST_FOREACH(mp, &g_classes, class) g_confdot_class(sb, mp); - sbuf_printf(sb, "};\n"); + sbuf_printf(sb, "}\n"); sbuf_finish(sb); } >Release-Note: >Audit-Trail: >Unformatted: