From owner-svn-src-all@FreeBSD.ORG Tue Dec 9 22:28:47 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 433FBC01; Tue, 9 Dec 2014 22:28:47 +0000 (UTC) Received: from mail-ie0-x22c.google.com (mail-ie0-x22c.google.com [IPv6:2607:f8b0:4001:c03::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0B289EB3; Tue, 9 Dec 2014 22:28:47 +0000 (UTC) Received: by mail-ie0-f172.google.com with SMTP id tr6so1540494ieb.3 for ; Tue, 09 Dec 2014 14:28:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=wpdmrjJ3PhJfEqQZCZZIeP3NC3Mo2OotY9o1gZO/qV8=; b=igGNCFqitlIUUVgJexfJEaCeqfe8oryvHgXzOliCkB/LKoOCLpozCmzQDhEi0VhBZ1 alZXKrr4y6cE/xG4AcTA34ReFM4yqDsGrfMyiTemtkejHzyHd7sCWgV95a7znu9aSNk0 MbEi/rhhCYOux8g464JGlEO7E2ErkPDjoFAzrbM7HWfdcHv3tg8wagZwhe6VdYny3xGH Cwz4M+bk3VbPXWpxjimuQczE3XPMC8P2MjUa+sCqE+G4U7TlOY8e4KHvrYqAkEH7inbt 2/3XvSIxOwljP00KCMtWz/D8NSvHfc9uh8IdlIafsBgJ5Wazu4MPBTQ7ZUrQxSLKQ1X+ d49A== MIME-Version: 1.0 X-Received: by 10.107.18.208 with SMTP id 77mr807645ios.57.1418164126248; Tue, 09 Dec 2014 14:28:46 -0800 (PST) Received: by 10.50.4.170 with HTTP; Tue, 9 Dec 2014 14:28:46 -0800 (PST) In-Reply-To: <201412092211.sB9MBvHO033086@svn.freebsd.org> References: <201412092211.sB9MBvHO033086@svn.freebsd.org> Date: Tue, 9 Dec 2014 14:28:46 -0800 Message-ID: Subject: Re: svn commit: r275657 - head/usr.sbin/pw/tests From: NGie Cooper To: Brad Davis Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Dec 2014 22:28:47 -0000 Hi Brad! On Tue, Dec 9, 2014 at 2:11 PM, Brad Davis wrote: > Author: brd (doc committer) > Date: Tue Dec 9 22:11:56 2014 > New Revision: 275657 > URL: https://svnweb.freebsd.org/changeset/base/275657 > > Log: > Add some tests for user modification. [1] > Fix a missing test in the Makefile from my previous commit. > > PR: 195834 [1] > Submitted by: Robert O'Neil > Approved by: will > > Added: > head/usr.sbin/pw/tests/pw_usermod.sh (contents, props changed) > Modified: > head/usr.sbin/pw/tests/Makefile > > Modified: head/usr.sbin/pw/tests/Makefile > ============================================================================== > --- head/usr.sbin/pw/tests/Makefile Tue Dec 9 21:43:03 2014 (r275656) > +++ head/usr.sbin/pw/tests/Makefile Tue Dec 9 22:11:56 2014 (r275657) > @@ -5,11 +5,13 @@ TESTSRC= ${.CURDIR}/../../../contrib/net > > TESTSDIR= ${TESTSBASE}/usr.sbin/pw > > -ATF_TESTS_SH= pw_etcdir pw_lock pw_groupmod pw_useradd pw_userdel > +ATF_TESTS_SH= pw_etcdir pw_lock pw_groupdel pw_groupmod pw_useradd pw_userdel pw_usermod Please put this one item per-line so it's easier to backport and doesn't exceed 80 columns. > +TEST_METADATA.pw_groupdel+= required_user="root" > TEST_METADATA.pw_groupmod+= required_user="root" > TEST_METADATA.pw_useradd+= required_user="root" > TEST_METADATA.pw_userdel+= required_user="root" > +TEST_METADATA.pw_usermod+= required_user="root" This should probably just be a for-loop, e.g. .for tp in ${ATF_TESTS_SH} TEST_METADATA.${tp}+= required_user="root" .endif