Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 17 Feb 2018 14:06:03 +0100
From:      Hans Petter Selasky <hps@selasky.org>
To:        Andrew Reilly <areilly@bigpond.net.au>, avg@freebsd.org
Cc:        current@freebsd.org, kib@freebsd.org
Subject:   Re: Since last week (today) current on my Ryzen box is unstable
Message-ID:  <e3ea22cd-ba73-a9d3-e1f1-fe530bf55e30@selasky.org>
In-Reply-To: <e320afc1-a9fa-10ae-7d50-f6a756aea599@selasky.org>
References:  <0CEA9D55-D488-42EC-BBDE-D0B7CE58BAEA@bigpond.net.au> <e320afc1-a9fa-10ae-7d50-f6a756aea599@selasky.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------9603A69FABAC7864CD02A28F
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit

On 02/17/18 13:42, Hans Petter Selasky wrote:
> On 02/17/18 13:16, Andrew Reilly wrote:
>> On a side-note, the new devmatch workings are giving me 43 boot 
>> warnings about "Malformed NOMATCH string: ''?'', and 
>> devmatch_enable="NO" in /etc/rc.conf doesn't seem to help, and the new 
>> matching is very very keen to load cc_vegas.ko, a lot.  Here's the 
>> output of devmatch -v, in case that helps:
> 
> Hi,
> 
> Does the attached patch solve the devmatch issue? Just apply it directly 
> on /etc and reboot.
> 
> --HPS
> 

Please find updated patch attached.

--HPS


--------------9603A69FABAC7864CD02A28F
Content-Type: text/x-patch;
 name="devmatch.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="devmatch.diff"

Index: etc/devd/devmatch.conf
===================================================================
--- etc/devd/devmatch.conf	(revision 329447)
+++ etc/devd/devmatch.conf	(working copy)
@@ -9,7 +9,7 @@
 #
 # Generic NOMATCH event
 nomatch 100 {
-	action "service devmatch start '?$_'";
+	action "/etc/rc.d/devmatch start '?$_'";
 };
 
 # Add the following to devd.conf to prevent this from running:
Index: etc/rc.d/devmatch
===================================================================
--- etc/rc.d/devmatch	(revision 329447)
+++ etc/rc.d/devmatch	(working copy)
@@ -37,13 +37,17 @@
 
 start_cmd="${name}_start"
 stop_cmd=':'
-[ -n "$2" ] && one_nomatch="-p '$2'"
+one_nomatch=$2
 
 devmatch_start()
 {
 	local x
 
-	x=$(devmatch ${one_nomatch} | sort -u)
+	if [ -n "$one_nomatch" ]; then
+		x=$(devmatch -p "${one_nomatch}" | sort -u)
+	else
+		x=$(devmatch | sort -u)
+	fi
 
 	[ -n "$x" ] || return
 

--------------9603A69FABAC7864CD02A28F--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e3ea22cd-ba73-a9d3-e1f1-fe530bf55e30>