From owner-freebsd-x11@FreeBSD.ORG  Thu Apr 26 15:45:15 2012
Return-Path: <owner-freebsd-x11@FreeBSD.ORG>
Delivered-To: x11@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E91CF106564A;
	Thu, 26 Apr 2012 15:45:15 +0000 (UTC)
	(envelope-from wblock@wonkity.com)
Received: from wonkity.com (wonkity.com [67.158.26.137])
	by mx1.freebsd.org (Postfix) with ESMTP id A20488FC15;
	Thu, 26 Apr 2012 15:45:15 +0000 (UTC)
Received: from wonkity.com (localhost [127.0.0.1])
	by wonkity.com (8.14.5/8.14.5) with ESMTP id q3QFjFVf021080;
	Thu, 26 Apr 2012 09:45:15 -0600 (MDT)
	(envelope-from wblock@wonkity.com)
Received: from localhost (wblock@localhost)
	by wonkity.com (8.14.5/8.14.5/Submit) with ESMTP id q3QFjElI021077;
	Thu, 26 Apr 2012 09:45:14 -0600 (MDT)
	(envelope-from wblock@wonkity.com)
Date: Thu, 26 Apr 2012 09:45:14 -0600 (MDT)
From: Warren Block <wblock@wonkity.com>
To: matt <sendtomatt@gmail.com>
In-Reply-To: <4F98F3BC.3020305@gmail.com>
Message-ID: <alpine.BSF.2.00.1204260912001.20978@wonkity.com>
References: <4F9541DD.3080200@netfence.it>
	<alpine.BSF.2.00.1204230648560.68901@wonkity.com>
	<4F956713.60604@gmail.com>
	<alpine.BSF.2.00.1204231032020.69711@wonkity.com>
	<4F979BCA.9050800@gmail.com> <4F98F3BC.3020305@gmail.com>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7
	(wonkity.com [127.0.0.1]); Thu, 26 Apr 2012 09:45:15 -0600 (MDT)
Cc: x11@freebsd.org, Andrea Venturoli <ml@netfence.it>,
	freebsd-ports@freebsd.org
Subject: Re: New X.Org
X-BeenThere: freebsd-x11@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: X11 on FreeBSD -- maintaining and support <freebsd-x11.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-x11>,
	<mailto:freebsd-x11-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-x11>
List-Post: <mailto:freebsd-x11@freebsd.org>
List-Help: <mailto:freebsd-x11-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-x11>,
	<mailto:freebsd-x11-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Apr 2012 15:45:16 -0000

On Thu, 26 Apr 2012, matt wrote:

>>>> Interesting. Another Radeon 4650 (rv730) is not working here, 
>>>> giving Bus Errors at the same address whenever certain applications 
>>>> are launched. Failing examples: Firefox, gedit, qt4-designer 
>>>> Successful: xfce4-terminal, ioquake3, compiz
>>
> Fixed this issue using the changes indicated in the below patch, which
> solved my issue with x bus errors. It looks like glxGetScreen was
> choking. This may help users with similar problems in compiz or Kwin.
> FYI I manually applied changes in the patch to x11-servers/xorg-server,
> not sure if the patch below would apply cleanly.
>
> diff --git a/glx/glxdri.c b/glx/glxdri.c
> index 326f539..f6ef784 100644
> --- a/glx/glxdri.c
> +++ b/glx/glxdri.c
> @@ -230,7 +230,7 @@ __glXDRIdrawableDestroy(__GLXdrawable *drawable)
>
>     /* If the X window was destroyed, the dri DestroyWindow hook will
>      * aready have taken care of this, so only call if pDraw isn't NULL. */
> -    if (drawable->pDraw != NULL) {
> +    if (drawable->pDraw != NULL && drawable->pDraw->type == DRAWABLE_WINDOW) {
> 	screen = (__GLXDRIscreen *) glxGetScreen(drawable->pDraw->pScreen);
> 	(*screen->core->destroyDrawable)(private->driDrawable);
>

Good catch!  Please enter a PR for this!