From owner-freebsd-current@FreeBSD.ORG Wed Feb 22 02:36:48 2006 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A6C316A420; Wed, 22 Feb 2006 02:36:48 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 566FB43D46; Wed, 22 Feb 2006 02:36:48 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id 136021A3C25; Tue, 21 Feb 2006 18:36:48 -0800 (PST) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id A0F25517D5; Tue, 21 Feb 2006 21:36:46 -0500 (EST) Date: Tue, 21 Feb 2006 21:36:46 -0500 From: Kris Kennaway To: John Baldwin Message-ID: <20060222023646.GA75290@xor.obsecurity.org> References: <200602211047.06599.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="k1lZvvs/B4yU6o8G" Content-Disposition: inline In-Reply-To: <200602211047.06599.jhb@freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: ups@freebsd.org, current@freebsd.org Subject: Re: [PATCH] possible fix for the runtime going backwards warnings X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Feb 2006 02:36:48 -0000 --k1lZvvs/B4yU6o8G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 21, 2006 at 10:47:04AM -0500, John Baldwin wrote: > The latest round of calcru() changes accidentally changed calccru() to us= e the=20 > wrong rusage_ext structure (p->p_rux vs p->p_crux) when calculating usage= =20 > times for children. The patch fixes calccru() to use p->p_crux again. I= t=20 > also moves the ruadd() in exit1() even later in the function so that it t= akes=20 > the dying thread's last time slice into account. Please test it and let = me=20 > know if it makes the messages go away (or if it makes things worse!) Tha= nks! >=20 > http://www.FreeBSD.org/~jhb/patches/calccru.patch I think you committed this already, right? I'm still getting calcru spam on the 3 SMP machines that I upgraded with fresh sources: Working revision: 1.284 Wed Feb 22 00:27:32 2006 Repository revision: 1.284 /c/ncvs/src/sys/kern/kern_exit.c,v Working revision: 1.155 Wed Feb 22 00:27:33 2006 Repository revision: 1.155 /c/ncvs/src/sys/kern/kern_resource.c,v calcru: runtime went backwards from 140475 usec to 140458 usec for pid 724 = (csh) u 9:54457/54961 s 14:86017/85496 i 0:1/1 calcru: runtime went backwards from 3855 usec to 3854 usec for pid 719 (csh) u 0:0/0 s 1:3855/3854 i 0:0/0 calcru: runtime went backwards from 19044 usec to 19043 usec for pid 713 (t= csh) u 2:8888/12695 s 1:10156/6347 i 0:0/1 calcru: runtime went backwards from 41540 usec to 41531 usec for pid 454 (n= fsd) u 4:27693/27687 s 2:13846/13843 i 0:1/1 calcru: runtime went backwards from 4552 usec to 4551 usec for pid 452 (mou= ntd) u 0:0/0 s 1:4552/4551 i 0:0/0 calcru: runtime went backwards from 564 usec to 563 usec for pid 140 (adjke= rntz) u 0:0/0 s 1:564/563 i 0:0/0 calcru: runtime went backwards from 78654 usec to 78637 usec for pid 20 (sw= i6: task queue) u 0:0/0 s 0:0/0 i 4:78654/78637 calcru: runtime went backwards from 38428 usec to 38420 usec for pid 0 (swa= pper) u 0:0/0 s 11:38428/38420 i 0:0/0 calcru: runtime went backwards from 1496715 usec to 1496579 usec for pid 32= (pagezero) u 0:0/0 s 199:1496715/1496579 i 0:0/0 calcru: runtime went backwards from 102337 usec to 102327 usec for pid 0 (s= wapper) u 0:0/0 s 41:102337/102327 i 0:0/0 calcru: runtime went backwards from 1461648 usec to 1461600 usec for pid 32= (pagezero) u 0:0/0 s 194:1461648/1461600 i 0:0/0 calcru: runtime went backwards from 100852 usec to 100848 usec for pid 0 (s= wapper) u 0:0/0 s 42:100852/100848 i 0:0/0 Kris --k1lZvvs/B4yU6o8G Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFD+84+Wry0BWjoQKURAq/PAJ9WYysaNYvAF9LENYHoqNfASlmYVQCg/bkj k0WvkYkBuptJKj4vx0IxjgY= =VfwC -----END PGP SIGNATURE----- --k1lZvvs/B4yU6o8G--