From owner-svn-ports-all@freebsd.org  Fri Nov 23 17:27:15 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id EB221114CDC4;
 Fri, 23 Nov 2018 17:27:14 +0000 (UTC)
 (envelope-from amdmi3@amdmi3.ru)
Received: from ihor-3.amdmi3.ru (ihor-3.amdmi3.ru [185.117.152.228])
 by mx1.freebsd.org (Postfix) with ESMTP id 303CE6D60F;
 Fri, 23 Nov 2018 17:27:12 +0000 (UTC)
 (envelope-from amdmi3@amdmi3.ru)
Received: from amdmi3.ru (localhost [127.0.0.1])
 by ihor-3.amdmi3.ru (Postfix) with SMTP id 592351AF134;
 Fri, 23 Nov 2018 20:27:06 +0300 (MSK)
Received: by amdmi3.ru (nbSMTP-1.00) for uid 1000
 amdmi3@amdmi3.ru; Fri, 23 Nov 2018 20:27:06 +0300 (MSK)
Date: Fri, 23 Nov 2018 20:26:45 +0300
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: Mathieu Arnold <mat@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r485586 - head/java/netty
Message-ID: <20181123172645.GB37389@hades.panopticon>
References: <201811220930.wAM9URj7056367@repo.freebsd.org>
 <20181122095930.fnfd4gpowkqehznp@atuin.in.mat.cc>
 <20181122125524.GA37389@hades.panopticon>
 <20181122161928.md57g2b2y7ctvkdb@atuin.in.mat.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20181122161928.md57g2b2y7ctvkdb@atuin.in.mat.cc>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Rspamd-Queue-Id: 303CE6D60F
X-Spamd-Result: default: False [0.77 / 15.00]; ARC_NA(0.00)[];
 NEURAL_HAM_MEDIUM(-0.21)[-0.205,0]; FROM_HAS_DN(0.00)[];
 RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[];
 TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain];
 DMARC_NA(0.00)[amdmi3.ru]; AUTH_NA(1.00)[];
 RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[ihor-3.amdmi3.ru];
 NEURAL_SPAM_LONG(0.43)[0.433,0];
 NEURAL_HAM_SHORT(-0.45)[-0.450,0]; R_SPF_NA(0.00)[];
 RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[];
 R_DKIM_NA(0.00)[]; IP_SCORE(0.00)[country: RU(0.01)];
 ASN(0.00)[asn:48666, ipnet:185.117.152.0/22, country:RU]
X-Rspamd-Server: mx1.freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Nov 2018 17:27:15 -0000

* Mathieu Arnold (mat@FreeBSD.org) wrote:


> > > > -PLIST_FILES=	%%JAVAJARDIR%%/netty-${PORTVERSION}.jar \
> > > > -		%%JAVAJARDIR%%/netty.jar
> > > > +PLIST_FILES=	${JAVAJARDIR:S,^${PREFIX}/,,}/netty-${PORTVERSION}.jar \
> > > > +		${JAVAJARDIR:S,^${PREFIX}/,,}/netty.jar
> > > 
> > > This seems overly complicated.  What is wrong with having just ${JAAAVJARDIR}?
> > 
> > It contains absolute path. I've assumed we don't use these in the plist.
> 
> Paths in the PLIST are either relative to PREFIX or absolute.  If a path
> is absolute and starts with PREFIX, it is just fine.

Got it, I've simplified these.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:              https://github.com/AMDmi3