From owner-svn-src-all@freebsd.org Mon Jul 8 19:13:12 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 396A515E7270; Mon, 8 Jul 2019 19:13:12 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4007386DC1; Mon, 8 Jul 2019 19:13:09 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 668A26F2; Mon, 8 Jul 2019 15:13:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 08 Jul 2019 15:13:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsco.org; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm3; bh=I qgh2AADiGI3tpyXdwWquI7SL4Wbzppis/u/n4uMVrk=; b=eWqdHb4M2Fzeikoof qwOSvD5DOTm4U9LerLt8drJ482S8fggOgEB3FzLTiTgWE3z459YmA1KQ1R4YNrSd wlwjJrhMfh/YKiJHGWEteC3nuUTtMV8OWqYIPkdB8dLErl1s8ezPXsRsxUQR0uml ketsJbNeFoB+mH94THaVVFp5W4cVpoRMQqdbeRtTHHNjlzU7HELvVglPb4OpqslX pAxx7WDzt7O4C6dvjrrNDUbjmCbjA8n23gVGt7GZrHVwUc0KUZ/pjIBrVNVI9Pme KzvlIbvZXS5mvKzX0vcqYwFLnTRD9p9ajgv35Vyev5orwdP4v01+Qr/VV1DA4u9C oqUPw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Iqgh2AADiGI3tpyXdwWquI7SL4Wbzppis/u/n4uMV rk=; b=JK0th8rWRVo6mE3u7kLe7YoXfB6n+sqBBjztbH/TIQXVqjdba1oefjvhM NOfdyqnQZ4MCUxA2j6kTFAZOrEwXzvcxfv+Kyi8QhN/XgKtZgTj0SCdZcgJajn5F uhLasvYIJp2EmxPq47+Ai1TZAqhHyD/T33M96sQ0SX45ILKUljusK1Jr21ydNl9B SQpVA1aTnW7c62WzFc9lBs4reYuiJRGXuNxGUjQr7PSctP5XizS1fhWtMjqEoyCa RKON6wDO4dSfH92VzcsgwypAZ5QpgiA+LIABEutXo91jDWH/MKykIP2xhohdpnrN 4XEwvh/ko5Q6QluAhBwgeHNncaQzw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrgedtgddufeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptggguffhjgffgffkfhfvofesthhqmhdthhdtjeenucfhrhhomhepufgtohht thcunfhonhhguceoshgtohhtthhlsehsrghmshgtohdrohhrgheqnecukfhppedujeegrd dvtdelrdeffedrudduvdenucfrrghrrghmpehmrghilhhfrhhomhepshgtohhtthhlsehs rghmshgtohdrohhrghenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from [172.20.10.2] (112.sub-174-209-33.myvzw.com [174.209.33.112]) by mail.messagingengine.com (Postfix) with ESMTPA id 54E24380075; Mon, 8 Jul 2019 15:13:00 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: svn commit: r349791 - head/sys/vm From: Scott Long In-Reply-To: <20190707023441.B2047@besplex.bde.org> Date: Mon, 8 Jul 2019 13:12:58 -0600 Cc: Doug Moore , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <4BC14FB0-F79B-48DA-98E1-40B20552EA11@samsco.org> References: <201907061555.x66FtGsg025314@repo.freebsd.org> <20190707023441.B2047@besplex.bde.org> To: Bruce Evans X-Mailer: Apple Mail (2.3445.104.11) X-Rspamd-Queue-Id: 4007386DC1 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=samsco.org header.s=fm3 header.b=eWqdHb4M; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=JK0th8rW; spf=pass (mx1.freebsd.org: domain of scottl@samsco.org designates 64.147.123.20 as permitted sender) smtp.mailfrom=scottl@samsco.org X-Spamd-Result: default: False [-6.57 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[samsco.org:s=fm3,messagingengine.com:s=fm3]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:64.147.123.20]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[samsco.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[samsco.org:+,messagingengine.com:+]; MX_GOOD(-0.01)[in2-smtp.messagingengine.com,in1-smtp.messagingengine.com,in2-smtp.messagingengine.com,in1-smtp.messagingengine.com,in2-smtp.messagingengine.com,in1-smtp.messagingengine.com,in2-smtp.messagingengine.com,in1-smtp.messagingengine.com]; NEURAL_HAM_SHORT(-0.98)[-0.976,0]; IP_SCORE(-3.48)[ip: (-9.46), ipnet: 64.147.123.0/24(-4.87), asn: 11403(-3.01), country: US(-0.06)]; FREEMAIL_TO(0.00)[optusnet.com.au]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:11403, ipnet:64.147.123.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[20.123.147.64.list.dnswl.org : 127.0.5.1] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jul 2019 19:13:12 -0000 Hi Bruce, This isn=E2=80=99t the first time I=E2=80=99ve witnessed your passion on = this topic. It would help immensely if there was some documentation, maybe in = /sys/sys/param.h, or maybe even in a manual page, on what a =E2=80=9Cclick=E2=80=9D is, = what a =E2=80=9Cdb=E2=80=9D is, why they=E2=80=99re important, and how they should be used. Do you have any documentation tucked away that could be edited and committed? Thanks, Scott > On Jul 6, 2019, at 11:48 AM, Bruce Evans wrote: >=20 > On Sat, 6 Jul 2019, Doug Moore wrote: >=20 >> Log: >> Fix style(9) violations involving division by PAGE_SIZE. >=20 > It is style violation to even use an explicit division by PAGE_SIZE > instead of the btoc() conversion macro (*).