From owner-svn-ports-all@FreeBSD.ORG  Sun Nov 25 03:22:52 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id CD9784B8;
 Sun, 25 Nov 2012 03:22:52 +0000 (UTC)
 (envelope-from wxs@atarininja.org)
Received: from syn.atarininja.org (syn.csh.rit.edu [129.21.49.45])
 by mx1.freebsd.org (Postfix) with ESMTP id 1DECB8FC16;
 Sun, 25 Nov 2012 03:22:52 +0000 (UTC)
Received: by syn.atarininja.org (Postfix, from userid 1001)
 id 0DAF45C34; Sat, 24 Nov 2012 22:22:45 -0500 (EST)
Date: Sat, 24 Nov 2012 22:22:45 -0500
From: Wesley Shields <wxs@FreeBSD.org>
To: Baptiste Daroussin <bapt@FreeBSD.org>
Subject: Re: svn commit: r307565 - head/net/silc-client
Message-ID: <20121125032245.GB10784@atarininja.org>
References: <201211191622.qAJGMZps097391@svn.freebsd.org>
 <20121120111700.GI71195@ithaqua.etoilebsd.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20121120111700.GI71195@ithaqua.etoilebsd.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Nov 2012 03:22:52 -0000

On Tue, Nov 20, 2012 at 12:17:00PM +0100, Baptiste Daroussin wrote:
> I know I already told you the following, but I think it is worth saying it
> loudly for other people who don't know yet about OPTIONS_DEFINE_${arch}
> 
> regards,
> Bapt
> 
> On Mon, Nov 19, 2012 at 04:22:35PM +0000, Wesley Shields wrote:
> > Author: wxs
> > Date: Mon Nov 19 16:22:34 2012
> > New Revision: 307565
> > URL: http://svnweb.freebsd.org/changeset/ports/307565
> > 
> ...
> >  WANT_PERL=	yes
> >  
> > -OPTIONS=	PTHREADS "Enable pthreads support" off \
> > -		IPV6 "Enable IPv6 support" on \
> > -		ICONV "Enable international character support" on \
> > -		PERL "Enable perl support" on \
> > -		OPTIMIZED_ASM "Use assembler optimizations (i386 only)" on
> > +OPTIONS_DEFINE=	PTHREADS IPV6 ICONV PERL OPTIMIZED_ASM
> > +PTHREADS_DESC=	"Enable pthreads support"
> > +OPTIMIZED_ASM_DESC=	"Use assembler optimizations (i386 only)"
> > +OPTIONS_DEFAULT=	IPV6 ICONV PERL OPTIMIZED_ASM
> 
> OPTIONS_DEFINE=	-PTHREADS IPV6 ICONV PERL
> OPTIONS_DEFINE_i386=	OPTIMIZED_ASM
> OPTIMIZED_ASM_DESC=	Use assembler optimizations
> ...
> > -.include <bsd.port.pre.mk>
> > +.include <bsd.port.options.mk>
> >  
> >  .if ${ARCH} != "i386"
> >  WITHOUT_OPTIMIZED_ASM=	yes
> >  .endif
> 
> The above is uneeded as OPTIMIZED_ASM will never get defined with the _arch
> syntax above.

Fixed all of these. Thanks for catching it and pointing me to the proper
way to do it!

I do have one question. In r307732 I had to change ${PERL} to just
'perl' in the PERL_ARCHNAME!= line. This was working prior to the switch
to the new options so I'm curious if I did something wrong or uncovered
a bug?

-- WXS