From owner-cvs-src@FreeBSD.ORG Sun Mar 19 11:30:45 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8B25816A420; Sun, 19 Mar 2006 11:30:45 +0000 (UTC) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 82FD043D4C; Sun, 19 Mar 2006 11:30:44 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id k2JBUgIJ067077; Sun, 19 Mar 2006 13:30:42 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ip.net.ua [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 76869-17-2; Sun, 19 Mar 2006 13:30:41 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id k2JBUJX0067050 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 19 Mar 2006 13:30:19 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.4/8.13.4) id k2JBUex9090338; Sun, 19 Mar 2006 13:30:40 +0200 (EET) (envelope-from ru) Date: Sun, 19 Mar 2006 13:30:39 +0200 From: Ruslan Ermilov To: Alexander Leidinger Message-ID: <20060319113039.GD89287@ip.net.ua> References: <200603191110.k2JBAYxC085982@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Qrgsu6vtpU/OV/zm" Content-Disposition: inline In-Reply-To: <200603191110.k2JBAYxC085982@repoman.freebsd.org> User-Agent: Mutt/1.5.11 X-Virus-Scanned: amavisd-new at ip.net.ua Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/linux32 linux32_sysvec.c syscalls.master src/sys/compat/linux linux_file.c linux_getcwd.c linux_ioctl.c linux_ipc.c linux_mib.c linux_misc.c linux_signal.c linux_socket.c linux_stats.c linux_sysctl.c linux_uid16.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Mar 2006 11:30:45 -0000 --Qrgsu6vtpU/OV/zm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Alexander, Linuxulator is still broken after my preliminary fix referenced below, on both amd64 and alpha. On amd64, it now stops here: : cc -c -O2 -frename-registers -pipe -fno-strict-aliasing -Wall -Wredundan= t-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointe= r-arith -Winline -Wcast-qual -Wundef -fformat-extensions -std=3Dc99 -g -no= stdinc -I- -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE= _KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=3D8= 000 --param inline-unit-growth=3D100 --param large-function-growth=3D1000 = -fno-omit-frame-pointer -mcmodel=3Dkernel -mno-red-zone -mfpmath=3D387 -mn= o-sse -mno-sse2 -mno-mmx -mno-3dnow -msoft-float -fno-asynchronous-unwind-= tables -ffreestanding -Werror /usr/src/sys/compat/linux/linux_stats.c : /usr/src/sys/compat/linux/linux_stats.c:233: warning: "struct linux_lstat= _args" declared inside parameter list : /usr/src/sys/compat/linux/linux_stats.c:233: warning: its scope is only t= his definition or declaration, which is probably not what you want : /usr/src/sys/compat/linux/linux_stats.c:234: warning: no previous prototy= pe for 'linux_lstat' : /usr/src/sys/compat/linux/linux_stats.c: In function `linux_lstat': : /usr/src/sys/compat/linux/linux_stats.c:242: error: dereferencing pointer= to incomplete type : /usr/src/sys/compat/linux/linux_stats.c:245: error: dereferencing pointer= to incomplete type : *** Error code 1 :=20 : Stop in /usr/obj/usr/src/sys/HAMMER. : *** Error code 1 On alpha/LINT, it will break similarly, because you didn't provide support for them. You obviously didn't build test your change on anything except i386, or you would notice that inclusion of "opt_compat.h" is needed so the sources can see the COMPAT_LINUX32/COMPAT_IA32 options. On Sun, Mar 19, 2006 at 11:10:33AM +0000, Ruslan Ermilov wrote: > ru 2006-03-19 11:10:33 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/amd64/linux32 linux32_sysvec.c syscalls.master=20 > sys/compat/linux linux_file.c linux_getcwd.c linux_ioctl.c=20 > linux_ipc.c linux_mib.c linux_misc.c=20 > linux_signal.c linux_socket.c=20 > linux_stats.c linux_sysctl.c=20 > linux_uid16.c=20 > Log: > Unbreak COMPAT_LINUX32 option support on amd64. > =20 > Broken by: netchild > =20 > Revision Changes Path > 1.17 +1 -0 src/sys/amd64/linux32/linux32_sysvec.c > 1.7 +1 -0 src/sys/amd64/linux32/syscalls.master > 1.94 +1 -0 src/sys/compat/linux/linux_file.c > 1.24 +1 -0 src/sys/compat/linux/linux_getcwd.c > 1.135 +2 -0 src/sys/compat/linux/linux_ioctl.c > 1.46 +2 -0 src/sys/compat/linux/linux_ipc.c > 1.26 +2 -0 src/sys/compat/linux/linux_mib.c > 1.175 +1 -0 src/sys/compat/linux/linux_misc.c > 1.54 +2 -0 src/sys/compat/linux/linux_signal.c > 1.65 +1 -0 src/sys/compat/linux/linux_socket.c > 1.78 +1 -0 src/sys/compat/linux/linux_stats.c > 1.17 +2 -0 src/sys/compat/linux/linux_sysctl.c > 1.19 +2 -0 src/sys/compat/linux/linux_uid16.c Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --Qrgsu6vtpU/OV/zm Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFEHUDfqRfpzJluFF4RAtQMAJ9qV2kVXxYnNWO/tnzzIlffnZCL1wCgnMd8 cXuVyqH4qPQrjyZ7QbhCagY= =ioJo -----END PGP SIGNATURE----- --Qrgsu6vtpU/OV/zm--