From nobody Thu Jun 12 01:40:23 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bHlbC43JRz5xqjw; Thu, 12 Jun 2025 01:40:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bHlbC36Zsz3k7M; Thu, 12 Jun 2025 01:40:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749692423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dymkXrRKnEYoXuxArmNYaG/Gjmkph9Z1EncT6iNlmyc=; b=AKc6hWlj8NzIjfvGwTWysZgJ4QxrokIT0oXEHKJ67e9pzEUyyJpI2bcGSyyjdsMG6FjCG0 +11t7SCeGca8bso6ZXQsj6/9jUS70gQa5jtK9vy4rMrP4B5jaO9dDLRy83l1UHP2ICdRPY OurURT+/CaGybLVRieGXCUNbIyDLiMnqe9SA9qFdQibNOOX79463iYFJrncLGlxJYajjAg BNrYxhfrYjRv0TFIeRbUzaCBi66MrQTka0ma0neh3FlRdlrmVonHKbRgAuoH8+p6WKXv1j vdXzyqxL9dah1PMv53Fx4YKDb+EYcepqziNkFBIEd2EXM/yZ4CatrQEehJmzUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749692423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dymkXrRKnEYoXuxArmNYaG/Gjmkph9Z1EncT6iNlmyc=; b=IVuBqyignywLGDRI0OuXEWhf3CYKkNBY3qlXsEZ5S6DbANY7PLD4+buHca07gVF+LYgVQC zgEiNGecPQjwz8TciEqZIY14QhVm8D7E4tDt84vUFHl2YNoyTqTIeke73bjXNHidMmKW/X QstlzdxsCjCpm3wn+mbAvw7rOgQB2y8oXGASKv7HruO4Qq4tg6tx3tu5bdFn1X21vYOJzW xT4chey3iEz1UR4MphJs6L5sR3o2SJniC7RSOJsIhkLmt0zZsyAsZFJQ+13Ktl7nwIzogp iWZlTvWFW399mn5iLEzh1xCWU3Re1VI8sRAlTepVSf5+CUqy2DIJ/PmrpBLFmQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1749692423; a=rsa-sha256; cv=none; b=xKn3CAc2Mhtg0AJfSd22KCestVatTrGVNHnvTmO3BB1U89dIW7xnyxGeyyzdz8TfMNC5xw jut6ivK6wS5rr597sK2plDDtOfRBWZc/fP3rTuBRz3KxAWOJA1H+Aw7qGYSioqU4jnC55J mBFiAKTgr99K3kPUMmuQSXdOcmcSbNP47axqhZmJFvo0hQIhqRXIp5kkvs62aNb+7/Btmh Xf2myan8F59KjxIh4dr1i2gnTPsakOGhZg5pbTs8RKl/OzjZR92oaFgAGYUdIVJj/fNbkX XqK0KWe5VUgJfQp3xdG+vF+iLJLg30gk8WTfWKczWEmi/Cr8dFMxPiid5pDNmg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bHlbC2D48zrky; Thu, 12 Jun 2025 01:40:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 55C1eNMT017626; Thu, 12 Jun 2025 01:40:23 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 55C1eNcY017623; Thu, 12 Jun 2025 01:40:23 GMT (envelope-from git) Date: Thu, 12 Jun 2025 01:40:23 GMT Message-Id: <202506120140.55C1eNcY017623@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Tai-hwa Liang Subject: git: 7dc4599cabd8 - stable/14 - net: bandaid for plugging a fw_com leak in fwip_detach() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: avatar X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 7dc4599cabd8e8e44a155e699ea0a85b23a06e73 Auto-Submitted: auto-generated The branch stable/14 has been updated by avatar: URL: https://cgit.FreeBSD.org/src/commit/?id=7dc4599cabd8e8e44a155e699ea0a85b23a06e73 commit 7dc4599cabd8e8e44a155e699ea0a85b23a06e73 Author: Tai-hwa Liang AuthorDate: 2024-02-15 01:00:49 +0000 Commit: Tai-hwa Liang CommitDate: 2025-06-12 01:23:51 +0000 net: bandaid for plugging a fw_com leak in fwip_detach() Adding a temporary workaround for plugging a fw_com upon if_fwip unloading. Steps to reproduce(needs two hosts connected with firewire): while true; do ifconfig fwip0 10.0.0.5 up fwcontrol -r ping -c 10.0.0.3 kldunload if_fwip done There's a chance that the unloading of if_fwip.ko triggers following warning: Warning: memory type fw_com leaked memory on destroy (1 allocations, 64 bytes leaked). commit d79b6b8ec267e7eef6e07cf4245159705e24acd5 (origin/main, origin/HEAD) (cherry picked from commit 25a5bb7318052322190a2880e0e7ef18e06d54bd) --- sys/net/if_fwsubr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/net/if_fwsubr.c b/sys/net/if_fwsubr.c index 2349ac35fc16..bf3362fc975c 100644 --- a/sys/net/if_fwsubr.c +++ b/sys/net/if_fwsubr.c @@ -802,6 +802,7 @@ firewire_ifdetach(struct ifnet *ifp) { bpfdetach(ifp); if_detach(ifp); + NET_EPOCH_DRAIN_CALLBACKS(); } void