Date: Sat, 25 May 2013 10:01:57 +0100 From: Chris Rees <crees@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, svn-ports-all@freebsd.org, Eitan Adler <eadler@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r318913 - in head/devel/libcfu: . files Message-ID: <CADLo83-E_f_B807XtUQzSccFjVPZDnLRFAJ6RePwCxa-ummr0w@mail.gmail.com> In-Reply-To: <20130525024425.GC89166@FreeBSD.org> References: <201305232205.r4NM5MSa002349@svn.freebsd.org> <20130524033728.GE48975@FreeBSD.org> <CAF6rxgkN7=X3X8gjdUAUNE881vgZU87uH7-YnEAScBti15k=Jg@mail.gmail.com> <20130525024425.GC89166@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 25 May 2013 03:44, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Fri, May 24, 2013 at 07:14:09PM +0200, Eitan Adler wrote: >> On 24 May 2013 05:37, Alexey Dokuchaev <danfe@freebsd.org> wrote: >> > On Thu, May 23, 2013 at 10:05:22PM +0000, Chris Rees wrote: >> >> New Revision: 318913 >> >> URL: http://svnweb.freebsd.org/changeset/ports/318913 >> >> >> >> Log: >> >> New versions of clang complain about assigning variables to themselves. >> >> >> >> Let's just remove -Werror and ignore the warnings. >> > >> > Hmm, wouldn't it be better to fix these bugs (judging from commit log it >> > should not be too hard) and send the patch upstream? >> >> I agree fixing these bugs is a good thing. I don't believe that this >> is a function of the ports team though. IMHO disabling warnings is >> the simplest, least intrusive patch that works. > > Good maintainer typically would work with upstream to make sure their > software builds and runs on FreeBSD with little possible special tuning > required. Not just it is "being nice", it also helps us to create and > maintain image of an OS that is worth writing software for. :) > > While I agree that investing time in a large complex patch when simple > workaround is available is a bit too much (unless port maintainer is also > on the upstream devteam), fixing *simple* things such as compiler warnings > is better than throwing -Werror. Yes, however this software hasn't been updated since 2005. I'll consider talking to upstream, but my priority at the time was to just get the stuff building and working-- it was a Thursday night and I had a load of Real Life work to do when I got the failure notification. Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83-E_f_B807XtUQzSccFjVPZDnLRFAJ6RePwCxa-ummr0w>