From nobody Fri Aug 7 21:05:17 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hGxWB449Sz6nlt2 for ; Fri, 07 Aug 2026 21:05:26 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic.asd.mail.yahoo.com (sonic-usea5-0027.asd.mail.yahoo.com [34.2.70.26]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4hGxWB1YJpz3LLm for ; Fri, 07 Aug 2026 21:05:26 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1786136723; bh=uBrgB8gGxOa8Wn4QSyjzdGS8PHz7Io+NL3Czq7twVic=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=EUA4aMaUlSRygmC8FXriqtgIPjNwu6mSoPQNeXjC8UQq4uUWNhgWEHMn84nuEZ6/4qmXmqZdcJmRlU2sa/dmJemK8DqlVERFkxtRDHmYYNIjZkAlElLDtY1ZUbHmy8OTAQ4M9YMA5u6C01KkGylBJUv2ffThimXxeb3IEY8bDO6gmPztAtaQBLzGipkBUmg1zi7qXD/K7mAozBTLF23/cuSNAEreaJjuE0GZq3W4yNRnaSkboGCCtrEyCw45z9snfz8NNNA/KltGL4MQB6hKnCBGmQCd784/d9qVn3abseF0IwqlgE5jKAHTC5jeTskMTHfCXKIoS204pU8qN+4sfQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1786136723; bh=P4f1Kr8RW3HeCZa9iRnMFBElsoFUJglivHLNYCe9B8l=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=i0CEqmS5V3ksL5ZmwktW53T40xcM88OQzYmbcxmFdULO5tKCDnBh6mWLddennf8/ZOX9Nga4dQe2mqZ15prwDzCRTyblo8dmso2jj8WP37b8g5OB3JAnO0YeoyRMh5I18WZgDg5fQUXIsrMFqk5VyU4sQGhE8SPKcL/qQML/SawSrIRixVWSEqniu80RNxpyqfOMEyn3zMEka9BstpDs7YJyyCJwjqjm12rVtKa0Sf1S9MQOWR5CQRskWjsIR/IQcYNn8LeZr1iSRJ6Y9ifM6eXvAlwNDIfE0DsvAisf2uvPqG5ZBU+8SDIaIRNMR1LmoULiJrrQyv+wMJ23YljcFg== X-YMail-OSG: n8t0Sy4VM1mhy4CHd6EGvpiJ_ylGtvIl8VPRowY_3w6KOo7gBOY0._9_BimqelY KgLDBA48GJk75Zy8HAh5LHnrLwbZagFldJBsIm5nlurmiptJLAlFlL3zHH5WsDI_ilYlsQGG2fSD 7PRevbSx5iFPPkmi17uHmmAAqYYUSHE0r8002LLIdVR4D.icTaaRUcUrZB_8ohE3WJVwSlgEzY2K l.DUTBt2T_YKH61JAMfem2x0A29RBxN9DsOs0pnrshgUn3Y9qOq64rD0qu.FXv25lCnZyA86wmzA S5dateDO7vJGgZN70eklCvBy5qHs9VNekrStOrvH3uFKekkf0g9kdCgf7x4.Z4R3_dq8wzo2Yy_6 O3gWrMLUVyP88gJpAkprHbKPDKmZPCrncWFTnadPcU3zgH_GA9I1kx0_ssJmBKWcfaNYHWVxV8Ra YbbWplZ5L2FqFtMp9_8gfOZj_QzuPOtVW1hiAxRXFsPFHYYNcWFsGGiZOCIJObOQ8dvvDe5B4Y.. rukmx7hUu6Z9NeDuujVP9vHtNq64MItg1Sda8qlAqbCf9OYZZa1I2c2nu1qojsNv0ftkgxgPFcE4 6SAaonT.f1_.y1tmZwsIU0HEQlAtPQu__C95_KgdLIwDESSX_7U4g8qG.bkRGT9pxbLJ8ISbixd_ 2smb.GLXtxajNjgc6MS1hC_3gzsqNvwFCMk3UQoNbk9IE_Zf4loXbqAva98jc6YsGoHt6ztlpBeK cUNF2JR3fsMuhwe7dd3FMDbrdFXdDmj90Bax37SWk_.kRRUA3ovUaW62058BajXmC18cVcPrhBHy HgRAYr31yoOUVjo3Slpe9zGHqJE4BmmxXU9OYMphHyvbQnFD5eFB5cgDbekKeuDA47AGu3yL4NUb 2XkluIJm6HZphkq.8fV5Jg6Ga.RpaAdZMECaKPosim6D87KJZ26gX_.eAzzHDT0uroTzhhZ3C226 uWshbGtRMIn2gviBKvv2kfxetOT7JQzZ13BCsrPJ6LeGTuIuOIMxsGqgffZiBuTcTQD0gs7s6z3c mJi1RV4zO7e6mVUQpjWjfoV6ZR9gC1L4tpxZgY3ENDMBlxiowWy2zh3nAxkw9dd.axJdpjMTGVeN RSVRIy7Bua6BHh6arezGPOuTBsExFb5uFeYrF..gy5QnwqUvQWMJ0B1A5_pCnEEl2TqW2iTL.XG6 lw.AYNHtF3KSCt1ol0AvV12EWM3nZORRWgxow5tgBAgYiaSG9I.RjGRiUmBuTZBvqb3Nt7fm6i24 Aed5LT2nvyV6yFSAEHf8bwzESU_z0TCjzm4X5QpH7Tp5oLy98o0fA6VKi_XWTUNPjjbK3addEymt E0.6XOFglQO0sb1oumk6EC4YMTxuOhM6a4BmzCUehDpKqdIdOrfYs1PWkM_R2APbOmciWmWbQd2n r4QdMrPFIYv2rdATrquNk7MtDRhAkvUiqppjGxYlo93uqXGDBO9I2GMauAf.6_CDpv_LX13ucVtR 8LEirojXVDTI04.btr40SaX7ZqL5iXCX_X.p6CkgSpw4RUl_xVH3jYegfOXUC8gKWLWUaG8Om4Ht omr8KQoyreq_rZDtXMUG6p1aIOFciTWe7Nk1Aq9GzyijxjigQ5W.047skbtULAD5PzYUqizHRcMw DmHF1yOgcxob53473HkwX26pdm21VfOX2AFe.1doySiIgN3tw0p3.ZcmyWBAEeHjPhNfs.01HaKA 9ywNDVwj6giBGoHSmBR8HKzAMyLuGetD6dhUuT2nR1flWWuTQbHyEVGpDOx31FsqNzn_hZffcBPG HdQS09l20CUT6hA5Yp6rSTtzUu0kPZzo9ELErnw0r.K0oDC_RS2LTu3Cw2HJtUAQdPZfo6rOc3q5 I5pQ8TcHZTsZX0y39PbGcqRR6LKCmNfwVobz1ccJXQivp7_r6.off.W.dPFyz8x2ZZrmUX.kUiDA VhulLXujTICf7qM.jrYPGIzgb9FCMbT7t9xmvNax4DMJ_9yjRutdE6YHul4Gi2sIjV7SM2UCqBb7 wfUhY_hnh2u4k5gm6CK6K.J30Li.ESp1u7CrJsQqHMX3iGnT.jCzJpeceA7wEFMSFUlPUqjc_Osj cEsMHWAKSlp8GdjVI4aGabdRHv4PCfA-- X-Sonic-MF: X-Sonic-ID: 48a4c8a3-4f77-486f-962f-bf07ca239d62 Received: from sonic.gate.mail.ne1.yahoo.com by mail-asdoutdeli-p-cin-usea5-prod-sonicconsumer-svc-102 with HTTP; Fri, 7 Aug 2026 21:05:23 +0000 Received: from dip11.lsn.gq1.yahoo.com ([67.195.161.20]) by hello (SMTP) with SMTP ID 6b43165e751f9c5d4d494bccb5aeddff; Fri, 07 Aug 2026 21:05:19 +0000 (UTC) Message-ID: <8c09ef72-bac2-414e-8670-9fa54a3d06c2@yahoo.com> Date: Fri, 7 Aug 2026 14:05:17 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 4bd01d6ae016 - main - fts: refactor to use fd-relative operations internally To: Mark Johnston , Alan Somers Cc: dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Jitendra Bhati References: <6a70e844.251cb.6995429f@gitrepo.freebsd.org> Content-Language: en-US From: Mark Millard In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.26276 mail.core.serving.mcws.prd.acl:role.token.mcws.jsmtp.yahoo X-Rspamd-Queue-Id: 4hGxWB1YJpz3LLm X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:34.2.70.0/23, country:US] X-Spamd-Bar: ---- On 8/7/26 08:30, Mark Johnston wrote: > On Thu, Aug 06, 2026 at 04:52:55PM -0600, Alan Somers wrote: >> On Tue, Aug 4, 2026 at 4:06 PM Mark Johnston wrote: >>> On Tue, Aug 04, 2026 at 01:33:40PM -0600, Alan Somers wrote: >>>> On Tue, Aug 4, 2026 at 1:00 PM Alan Somers wrote: >>>>> >>>>> On Tue, Aug 4, 2026 at 12:58 PM Mark Johnston wrote: >>>>>> >>>>>> On Mon, Aug 03, 2026 at 07:13:08PM +0000, Alan Somers wrote: >>>>>>> The branch main has been updated by asomers: >>>>>>> >>>>>>> URL: https://cgit.FreeBSD.org/src/commit/?id=4bd01d6ae01632501b63438b8d9a401db9744a78 >>>>>>> >>>>>>> commit 4bd01d6ae01632501b63438b8d9a401db9744a78 >>>>>>> Author: Jitendra Bhati >>>>>>> AuthorDate: 2026-06-12 17:07:55 +0000 >>>>>>> Commit: Alan Somers >>>>>>> CommitDate: 2026-08-03 19:12:28 +0000 >>>>>>> >>>>>>> fts: refactor to use fd-relative operations internally >>>>>>> >>>>>>> Replace all _open() calls with _openat() in __fts_open(), fts_read(), >>>>>>> and fts_children(). Replace statfs() with _fstatfs(). >>>>>>> >>>>>>> Add fts_dirfd to struct _ftsent, set to the file descriptor of the >>>>>>> parent directory. Callers can use openat(ent->fts_dirfd, ent->fts_name, >>>>>>> ...) to access files safely without relying on fts_accpath, which >>>>>>> enables programs in capability mode to open the files described by >>>>>>> _ftsent. >>>>>>> >>>>>>> This is a preparatory change for fts_openat() which will allow callers >>>>>>> to provide a pre-opened directory fd, enabling fts(3) traversal inside >>>>>>> Capsicum capability mode. >>>>>>> >>>>>>> Mirror all fts_open() changes to fts_open_b(). >>>>>>> >>>>>>> As a result of expanding _ftsend, publish new ELF symbol versions for >>>>>>> fts_openat and related functions. >>>>>>> >>>>>>> Sponsored by: Google LLC (GSoC 2026) >>>>>>> Reviewed by: asomers >>>>>>> Pull Request: https://github.com/freebsd/freebsd-src/pull/2303 >>>>>> >>>>>> Quite a few regression tests seem to be failing after this commit, e.g., >>>>>> some of the makefs tests: https://ci.freebsd.org/job/FreeBSD-main-amd64-test/29201/ >>>>> >>>>> I'm testing a fix now. I should have something ready for you soon. >> >> The fix is committed now, as 74bd6fb1eb02 . Sorry for the trouble. > > Thanks, but I think there are still some problems. I'm still seeing > vnode exhaustion while running the test suite. > > First, fts_build() appears to dup() the directory entry into every > single(!) child FTS entry. That's slow and means that we'll potentially > acquire a large number of fds when traversing a wide directory, enough > to hit per-process fd limits. Second, the return value from dup() is > not checked, and it's not clear to me whether that's handled elsewhere. > Finally, I'm fairly sure these dup()ed fds are leaked in various places; > for instance, isn't fts_lfree() potentially leaking the dirfd of each > entry it frees? > > The first and last issues are probably straightforward to fix, but I'm > not sure about the second one. I don't think FTS can reasonably consume > an fd for every entry in a directory, that's going to cause a lot of > problems. > > A question showed up on Discord's area for FreeBSD ports : QUOTE Ooo could this also be related to why I’m getting “too many open files” errors from poudriere when building things like go and rust? END QUOTE This was from someone that had progressed to/past 74bd6fb1eb02 in order to avoid the prior poudriere(-devel) problems they were having. (I'm still synchronized to before the problems started.) -- === Mark Millard marklmi at yahoo.com