From owner-freebsd-current@FreeBSD.ORG Thu Apr 1 20:07:25 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1E397106564A for ; Thu, 1 Apr 2010 20:07:25 +0000 (UTC) (envelope-from delphij@gmail.com) Received: from mail-pw0-f54.google.com (mail-pw0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id E4DFB8FC08 for ; Thu, 1 Apr 2010 20:07:24 +0000 (UTC) Received: by pwi9 with SMTP id 9so1472804pwi.13 for ; Thu, 01 Apr 2010 13:07:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=zeBG70kRt5IipRzKyXQCmW4UHa8hFrrZAvOZMB94q70=; b=JwrxbfAKomfX7KVTa3vE2nlKncC3xGwyN0VdhW6NHcQBTz2okpPb8k7V/VqfD2dhuq zaH9wwsNagmKblwU6hDzcsyO8/JgOhBqHdxL9Dggd+Ug3Ii5ZN0jJpIry6dio+h46zFt AXGeiMNqgkFozEQPmGfrZq/HyusTs6677ab50= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=e6cb/qVUALlsTravaeCWAnvInHNdxi9uGLHkMRMD1UVTzsjwdRcPFrAXu6011BiiEP VMh8S/ub0RaC9tcFvRZavMnn/f68a9reawX1upILuOnMVtnk5MqceL7udl/16JiLULBU 8dL4PITB0/ZAypqDbdueYkkdsNzTXl200l5lU= MIME-Version: 1.0 Received: by 10.140.127.14 with HTTP; Thu, 1 Apr 2010 13:07:24 -0700 (PDT) In-Reply-To: <4BB4FB35.2040703@uffner.com> References: <4BA7E0B8.3080406@delphij.net> <4BAE2B4F.6060005@protected-networks.net> <4BB3FD5D.9070600@uffner.com> <4BB4FB35.2040703@uffner.com> Date: Thu, 1 Apr 2010 13:07:24 -0700 Received: by 10.141.3.1 with SMTP id f1mr744187rvi.26.1270152444475; Thu, 01 Apr 2010 13:07:24 -0700 (PDT) Message-ID: From: Xin LI To: Tom Uffner Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org Subject: Re: HEADSUP: zlib updated [svn commit: r205471 - in head: . lib/libz lib/libz/contrib lib/libz/doc sys/sys] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2010 20:07:25 -0000 On Thu, Apr 1, 2010 at 12:59 PM, Tom Uffner wrote: > Xin LI wrote: >> >> On Wed, Mar 31, 2010 at 6:56 PM, Tom Uffner =C2=A0wrote: >>> >>> Michael Butler wrote: >>> >>>> This breaks most (if not all) of the QT4-dependent ports for the lack = of >>>> a definition of "off64_t". >>> >>> it also breaks multimedia/mplayer, graphics/ImageMagick, and >>> print/ghostscript8 & everything that depends on it. >> >> Just because they used to compile DOES NOT mean they were right. =C2=A0I= t's >> NOT right to define _LARGEFILE64_SOURCE on FreeBSD, see: >> >> http://www.delorie.com/gnu/docs/glibc/libc_13.html > > i realize this. i was just adding to the list of ports that no longer > build after this change. ghostscript is kind of important for print > support. > > i doubt this is "right" either, but it is a quick & dirty way to > make mplayer compile again: > > --- configure.orig =C2=A0 =C2=A0 =C2=A02010-04-01 15:49:37.000000000 -040= 0 > +++ configure =C2=A0 2010-04-01 15:50:50.000000000 -0400 > @@ -5337,7 +5337,7 @@ > =C2=A0#include > =C2=A0int main(void) { return 0; } > =C2=A0EOF > - =C2=A0 =C2=A0cc_check -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=3D64 > -D_LARGEFILE64_SOURCE \ > + =C2=A0 =C2=A0cc_check -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=3D64 \ > =C2=A0 =C2=A0 =C2=A0 -ldvdread $_ld_dl && _dvdread=3Dyes && _res_comment= =3D"external" > =C2=A0 fi > =C2=A0fi > @@ -7412,8 +7412,6 @@ > =C2=A0if test "$_largefiles" =3D yes || freebsd ; then > =C2=A0 CFLAGS=3D"$CFLAGS -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=3D64" > =C2=A0 if test "$_dvdread" =3D yes || test "$_libdvdcss_internal" =3D yes= ; then > - =C2=A0 =C2=A0# dvdread support requires this (for off64_t) > - =C2=A0 =C2=A0CFLAGS=3D"$CFLAGS -D_LARGEFILE64_SOURCE" > =C2=A0 =C2=A0 cygwin && CFLAGS=3D"$CFLAGS -DSYS_CYGWIN" > =C2=A0 fi > =C2=A0fi I think the latest (1.2.4.1) zlib has a bug that prevents using -D_LARGEFILE64_SOURCE at all, and expects -D_LARGEFILE64_SOURCE=3D1. I'll submit a patch to upstream :( Cheers, --=20 Xin LI http://www.delphij.net