Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 3 Jan 2019 22:54:22 +0100
From:      Tobias Kortkamp <tobik@freebsd.org>
To:        Sean Bruno <sbruno@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r489228 - in head/audio: clementine-player clementine-player/files libechonest
Message-ID:  <20190103215421.GA13148@urd.tobik.me>
In-Reply-To: <201901032143.x03LhwZl017869@repo.freebsd.org>
References:  <201901032143.x03LhwZl017869@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--BXVAT5kNtrzKuDFl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 03, 2019 at 09:43:58PM +0000, Sean Bruno wrote:
> Author: sbruno
> Date: Thu Jan  3 21:43:57 2019
> New Revision: 489228
> URL: https://svnweb.freebsd.org/changeset/ports/489228
>=20
> Log:
>   audio/clementine-player:  Jump to qt5
>   - regenerate some of the patch files for this new branch
>   - cleanup and try to adjust Makefile
>  =20
>   audio/libechonest: Jump to qt5
>   - clementine-player is the only port that I could find that has an expl=
icit
>     dependency on libechonest.  Commit this update so there is no window =
for
>     build failures.
>  =20
>   Test built on 13-CURRENT, 12-STABLE, 11-STABLE across i386 and amd64.
>   Run-time tested on 13-CURRENT, amd64.
>  =20
>   PR:		234534 226529
>   Submitted by:	greg@unrelenting.technology
>=20
> Added:
>   head/audio/clementine-player/files/patch-3rdparty_libprojectm_MilkdropP=
resetFactory_Parser.cpp   (contents, props changed)
>   head/audio/clementine-player/files/patch-3rdparty_libprojectm_Renderer_=
VideoEcho.cpp   (contents, props changed)
> Deleted:
>   head/audio/clementine-player/files/patch-3rdParty_libprojectm_MilkdropP=
resetFactory_Parser.cpp
>   head/audio/clementine-player/files/patch-3rdParty_libprojectm_Renderer_=
VideoEcho.cpp
> Modified:
>   head/audio/clementine-player/Makefile
>   head/audio/clementine-player/distinfo
>   head/audio/clementine-player/files/patch-CMakeLists.txt
>   head/audio/clementine-player/files/patch-dist_clementine.desktop
>   head/audio/clementine-player/files/patch-src_CMakeLists.txt
>   head/audio/clementine-player/pkg-plist
>   head/audio/libechonest/Makefile
>   head/audio/libechonest/pkg-plist
>=20
> Modified: head/audio/clementine-player/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/audio/clementine-player/Makefile	Thu Jan  3 21:40:51 2019	(r4892=
27)
> +++ head/audio/clementine-player/Makefile	Thu Jan  3 21:43:57 2019	(r4892=
28)
> @@ -2,64 +2,61 @@
>  # $FreeBSD$
> =20
>  PORTNAME=3D	clementine
> [...]
>  USE_XORG=3D	x11
> =20
> -CONFLICTS_BUILD=3D	qt-3.*
> -USE_QT=3D		corelib \
> +USE_QT=3D		buildtools \

Does clementine-player, a music player, really need qt5-buildtools
at runtime or should this be buildtools_build instead?

> +		concurrent \
> +		core \
>  		dbus \
>  		gui \
>  		imageformats \
> -		qmake_build \
>  		linguist_build \
> -		moc_build \
>  		network \
>  		opengl \
> -		qtestlib \
> -		rcc_build \
> +		qmake_build \
> +		testlib \

Same here.  Does it really need qt5-testlib at runtime?


--BXVAT5kNtrzKuDFl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAlwuhItfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1
N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF
H2H7sgf/cTPqChIyErk5ahnV93NzgrRPa0JwwoZsOQPPYw7vl6AfTaxAGBFeG96G
SuFKNq9RNlD5CLuLQJGnbpGr6BfQ95joN0ulIm3gXxx/zN/a4otvEE3RAk1/K/Ls
+nNxyfTfIXbUTlLqxuybyX8WItc/RIDL+7xg+J0mz4290oEHp4pwwRVmuSfmfire
vXv0Mb/6G88T0UrjHpQDwfU1A7ltpSnDlQUgaW82xUlYnrCTcX8uxH4bAmo3AChw
qF0DwNCdyZxQ6mTfD1nbUTpBNQoKoPADEc70WEFbUS8ErMseWPGlrMQMNkEax7aM
ItOvVYL6GzltYSJ81Be7ij+kRNNH1g==
=pIWa
-----END PGP SIGNATURE-----

--BXVAT5kNtrzKuDFl--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190103215421.GA13148>