From owner-cvs-all@FreeBSD.ORG Mon May 30 11:30:41 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E598C16A41C; Mon, 30 May 2005 11:30:41 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0F27243D4C; Mon, 30 May 2005 11:30:40 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j4UBUdDm014257; Mon, 30 May 2005 14:30:39 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 71463-18; Mon, 30 May 2005 14:30:38 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j4UBUcXg014253 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 30 May 2005 14:30:38 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.3/8.13.3) id j4UBV146055476; Mon, 30 May 2005 14:31:01 +0300 (EEST) (envelope-from ru) Date: Mon, 30 May 2005 14:31:01 +0300 From: Ruslan Ermilov To: Maxim.Sobolev@portaone.com Message-ID: <20050530113101.GH54585@ip.net.ua> References: <200505292105.j4TL5w32038570@repoman.freebsd.org> <20050530104131.GB54585@ip.net.ua> <429AF57A.5060902@portaone.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7J16OGEJ/mt06A90" Content-Disposition: inline In-Reply-To: <429AF57A.5060902@portaone.com> User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new at ip.net.ua Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libstand Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 May 2005 11:30:42 -0000 --7J16OGEJ/mt06A90 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 30, 2005 at 02:14:02PM +0300, Maxim Sobolev wrote: > Ruslan Ermilov wrote: > >Hi, > > > >On Sun, May 29, 2005 at 09:05:58PM +0000, Maxim Sobolev wrote: > > > >>sobomax 2005-05-29 21:05:58 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> lib/libstand Makefile=20 > >> Log: > >> Add missed ${.CURDIR}/../../contrib/bzip2 into include search path,=20 > >> otherwise > >> old version of bzlib.h can be picked up from the /usr/include. > >>=20 > >> Revision Changes Path > >> 1.51 +1 -1 src/lib/libstand/Makefile > >> > > > >Changes like this, while harmless, unnecessarily pollute makefiles. > >During buildworld we first install new headers then build new > >libraries then the rest. When doing standalone compiles, the same > >procedure should generally be followed. (Otherwise, you'd end up > >changing every utility's makefile that uses libstand to add this > >-I to CFLAGS.) >=20 > This is incorrect assertion since libstand hides implementation details,= =20 > so that it is not necessary to include bzlib.h into code which uses=20 > libstand. >=20 But if you were to standalone test the build of loader(8) with an updated libstand library, you'd have to (as an alternative to a full "make buildworld"): 1. build/install updated headers 2. build/install updated libstand 3. build loader My point was to let you know that what you did was not necessary for a normal "make buildworld" case (contrary to the commit log), and is only useful in standalone compile, and its usefullness is only limited to building the library itself, not its consumers. I don't ask you to take any actions, but if you feel like refining a commit log this would be appreciated. :-) Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --7J16OGEJ/mt06A90 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFCmvl1qRfpzJluFF4RAsLzAKCagYE7sjraCbsO8orUjsnaoeQisgCdGFDf k1qehp3WoF9zcnuuXRNicNw= =Dccx -----END PGP SIGNATURE----- --7J16OGEJ/mt06A90--