From owner-freebsd-bugs  Sun Mar 19 01:55:48 1995
Return-Path: bugs-owner
Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id BAA01162 for bugs-outgoing; Sun, 19 Mar 1995 01:55:48 -0800
Received: from Root.COM (implode.Root.COM [198.145.90.1]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id BAA01156 for <bugs@freebsd.org>; Sun, 19 Mar 1995 01:55:45 -0800
Received: from corbin.Root.COM (corbin.Root.COM [198.145.90.18]) by Root.COM (8.6.8/8.6.5) with ESMTP id BAA21457; Sun, 19 Mar 1995 01:55:41 -0800
Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.11/8.6.5) with SMTP id BAA00566; Sun, 19 Mar 1995 01:55:41 -0800
Message-Id: <199503190955.BAA00566@corbin.Root.COM>
X-Authentication-Warning: corbin.Root.COM: Host localhost didn't use HELO protocol
To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch)
cc: scott@zorch.sf-bay.org (Scott Hazen Mueller), bugs@FreeBSD.org
Subject: Re: bug in libc 
In-reply-to: Your message of "Sun, 19 Mar 95 10:12:05 +0100."
             <199503190912.KAA08151@uriah.heep.sax.de> 
From: David Greenman <davidg@Root.COM>
Reply-To: davidg@Root.COM
Date: Sun, 19 Mar 1995 01:55:37 -0800
Sender: bugs-owner@FreeBSD.org
Precedence: bulk

>As Scott Hazen Mueller wrote:
>> 
>> rpc/auth_unix.c
>> 
>> sense of test for authunix_maxgrouplist being changed is backwards.
>> 
>> *** auth_unix.c	Fri Mar 17 14:44:56 1995
>> --- auth_unix.c.orig	Fri Mar 17 14:44:30 1995
>> ***************
>> *** 149,155 ****
>>   	aup.aup_gid = gid;
>>   	/* GW: continuation of max group list hack */
>>   	if(authunix_maxgrouplist != 0) {
>> ! 		aup.aup_len = ((len < authunix_maxgrouplist) ? len 
>>   			       : authunix_maxgrouplist);
>
>What's wrong here?
>
>If the actual lenght is *less* than the maximum, the actual value will
>be used, otherwise the length will be limited to the maximum.  Seems
>to be reasonable to me.

   That's what he changed it to. He did the diff backwards.

-DG