From owner-cvs-src@FreeBSD.ORG  Thu Jan  8 00:05:24 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D051116A4CE; Thu,  8 Jan 2004 00:05:24 -0800 (PST)
Received: from phantom.cris.net (phantom.cris.net [212.110.130.74])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id CD08043D5E; Thu,  8 Jan 2004 00:05:16 -0800 (PST)
	(envelope-from ru@FreeBSD.org.ua)
Received: from phantom.cris.net (ru@localhost [127.0.0.1])
	by phantom.cris.net (8.12.10/8.12.10) with ESMTP id i0885El7027982;
	Thu, 8 Jan 2004 10:05:14 +0200 (EET)
	(envelope-from ru@FreeBSD.org.ua)
Received: (from ru@localhost)
	by phantom.cris.net (8.12.10/8.12.10/Submit) id i0885ERI027977;
	Thu, 8 Jan 2004 10:05:14 +0200 (EET)
	(envelope-from ru)
Date: Thu, 8 Jan 2004 10:05:14 +0200
From: Ruslan Ermilov <ru@FreeBSD.org>
To: "Brian F. Feldman" <green@FreeBSD.org>
Message-ID: <20040108080514.GB27761@FreeBSD.org.ua>
References: <20040107202112.GD21522@FreeBSD.org.ua>
	<200401072041.i07Kf4Th004736@green.bikeshed.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="X1bOJ3K7DJ5YkBrT"
Content-Disposition: inline
In-Reply-To: <200401072041.i07Kf4Th004736@green.bikeshed.org>
User-Agent: Mutt/1.5.5.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/share/mk bsd.obj.mk
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Jan 2004 08:05:25 -0000


--X1bOJ3K7DJ5YkBrT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 07, 2004 at 03:41:03PM -0500, Brian F. Feldman wrote:
> Ruslan Ermilov <ru@FreeBSD.org> wrote:
> > On Thu, Jan 01, 2004 at 09:05:48PM -0800, Brian Feldman wrote:
> > > green       2004/01/01 21:05:48 PST
> > >=20
> > >   FreeBSD src repository
> > >=20
> > >   Modified files:
> > >     share/mk             bsd.obj.mk=20
> > >   Log:
> > >   Fix a very corner case when you want to make cleandir SUBDIRs which
> > >   are built using a ${MAKE} that's not just "make".
> > >  =20
> > >   Test by:        make universe (followed by cleandirs)
> > >  =20
> > >   Revision  Changes    Path
> > >   1.49      +2 -2      src/share/mk/bsd.obj.mk
> > >=20
> > The old version used ${MAKE}, why this was a problem at all?
>=20
> The ${MAKE} that it uses would be overridden by the default ${MAKE} value=
=20
> each time; this doesn't occur when dependencies are executed, though.
>=20
Please explain in more detail.  With the below makefile,

: all:
: 	@cd ${.CURDIR}; ${MAKE} print-make
:=20
: print-make:
: 	@echo ${MAKE}

running /usr/bin/make will rightfully print "/usr/bin/make".
make(1)'s main() always sets MAKE to argv[0] as its first task.


Cheers,
--=20
Ruslan Ermilov
FreeBSD committer
ru@FreeBSD.org

--X1bOJ3K7DJ5YkBrT
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQE//Q85Ukv4P6juNwoRAuxXAJ4r7RhqSad+L+ekbP72lG6h6GHnuwCgh2u5
St0WMf8vxntfkw7ED/ktQKw=
=vmZ3
-----END PGP SIGNATURE-----

--X1bOJ3K7DJ5YkBrT--