From owner-freebsd-geom@FreeBSD.ORG Tue Feb 1 19:18:40 2011 Return-Path: Delivered-To: geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6573A106576A for ; Tue, 1 Feb 2011 19:18:40 +0000 (UTC) (envelope-from mj@feral.com) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.freebsd.org (Postfix) with ESMTP id F261C8FC1F for ; Tue, 1 Feb 2011 19:18:39 +0000 (UTC) Received: from [192.168.221.2] (remotevpn [192.168.221.2]) by ns1.feral.com (8.14.4/8.14.3) with ESMTP id p11IdNsM056070 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Tue, 1 Feb 2011 10:39:24 -0800 (PST) (envelope-from mj@feral.com) Message-ID: <4D485356.3000908@feral.com> Date: Tue, 01 Feb 2011 10:39:18 -0800 From: Matthew Jacob Organization: Feral Software User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7 MIME-Version: 1.0 To: geom@freebsd.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender DNS name whitelisted, not delayed by milter-greylist-4.2.6 (ns1.feral.com [192.168.221.1]); Tue, 01 Feb 2011 10:39:24 -0800 (PST) Cc: Subject: setting a dump device as a side effect of getattr X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Feb 2011 19:18:40 -0000 The current mechanism for setting a dump device is to run down the list of geoms and call set_dumper at the bottom layer. Would anyone object to making the caller of the GETTATTR for GEOM::kerneldump responsible for calling set_dumper (if desired)? This gives systems some flexibility in changing or extending dump devices w/o having to play games witth doing save of the current dumper, calling the GETATTR, restoring the current dumper and so on.