From owner-freebsd-sparc64@FreeBSD.ORG Tue Dec 28 18:11:01 2010 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7D54E106564A; Tue, 28 Dec 2010 18:11:01 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 47E138FC1D; Tue, 28 Dec 2010 18:11:01 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id E4C3246B03; Tue, 28 Dec 2010 13:11:00 -0500 (EST) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 20A7A8A009; Tue, 28 Dec 2010 13:11:00 -0500 (EST) From: John Baldwin To: freebsd-sparc64@freebsd.org Date: Tue, 28 Dec 2010 13:10:50 -0500 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20101102; KDE/4.4.5; amd64; ; ) References: <20101228132703.GC68770@gahrfit.gahr.ch> <20101228173529.GA38083@alchemy.franken.de> In-Reply-To: <20101228173529.GA38083@alchemy.franken.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201012281310.50739.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Tue, 28 Dec 2010 13:11:00 -0500 (EST) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: Marius Strobl Subject: Re: [patch] rename macro parameter list in cpufunc.h X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Dec 2010 18:11:01 -0000 On Tuesday, December 28, 2010 12:35:29 pm Marius Strobl wrote: > On Tue, Dec 28, 2010 at 02:27:04PM +0100, Pietro Cerutti wrote: > > Dear all, > > > > sys/sparc64/include/cpufunc.h defines macro having a parameter named > > 'xor'. This is a reserved keyword in C++. For this reason, it is > > impossible to use this header in C++ (e.g., by including > > machine/atomic.h). > > > > This patch [1] renames these parameters to _xor. Please review and/or > > approve (I need an explicit approval in order to commit to src). > > > > Thanks! > > > > Best Regards, > > > > [1] http://people.freebsd.org/~gahr/cpufunc.h.diff > > Hrm, I really don't like the inconsistency only renaming "xor" > introduces, rototilling the whole file also seems excessive though > (also that would get it closer to style(9)). Would wrapping it in > __BEGIN_DECLS or something like that work as an alternate solution? Not for a reserved word like 'class'. Maybe you could rename 'xor' to something else like 'mask' instead? -- John Baldwin