From owner-freebsd-current  Sat Dec 20 10:27:28 1997
Return-Path: <owner-freebsd-current>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id KAA02543
          for current-outgoing; Sat, 20 Dec 1997 10:27:28 -0800 (PST)
          (envelope-from owner-freebsd-current)
Received: from whistle.com (s205m131.whistle.com [207.76.205.131])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id KAA02537;
          Sat, 20 Dec 1997 10:27:11 -0800 (PST)
          (envelope-from archie@whistle.com)
Received: (from smap@localhost) by whistle.com (8.7.5/8.6.12) id KAA05089; Sat, 20 Dec 1997 10:26:40 -0800 (PST)
Received: from bubba.whistle.com(207.76.205.7) by whistle.com via smap (V1.3)
	id sma005085; Sat Dec 20 10:26:30 1997
Received: (from archie@localhost) by bubba.whistle.com (8.8.7/8.6.12) id KAA19822; Sat, 20 Dec 1997 10:26:30 -0800 (PST)
From: Archie Cobbs <archie@whistle.com>
Message-Id: <199712201826.KAA19822@bubba.whistle.com>
Subject: Re: Bruce vandalism again
In-Reply-To: <199712201419.HAA24217@mt.sri.com> from Nate Williams at "Dec 20, 97 07:19:07 am"
To: nate@mt.sri.com (Nate Williams)
Date: Sat, 20 Dec 1997 10:26:30 -0800 (PST)
Cc: dyson@FreeBSD.ORG, gurney_j@resnet.uoregon.edu, julian@whistle.com,
        bde@FreeBSD.ORG, current@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL31 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-current@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

Nate Williams writes:
> > John-Mark Gurney said:
> > If style(9) is broken, which apparently it is, then it should be fixed.
> > It isn't a religious document, but one that should change with the times.
> 
> I disagree.  I'm with Bruce here in that you shouldn't 'bit by bit'
> change code to use new ANSI prototypes *UNLESS* you change all of the
> code to use ANSI prototypes.  So, either convert them all to the new
> style (my preference), or leave them all the old style, but having a
> mix/match of both is silly.
> 
> And, if you want to change it all to the new style, make the 'style'
> changes commits separate from the functional changes commits so one can
> see the functionality changes easy w/out having to dig through the style
> changes.

OK, so here's a thought experiment:

Suppose somebody suddenly showed up with a giant patch file that:

 (a) Got rid of all uses of __P() in the kernel (ie, unwrapped them
     so that all function declarations used ANSI protptypes)
 (b) Changed every function definition to use ANSI prototypes as well

Would it get committed?

-Archie

PS. Be careful how you answer... :-)

___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com