From owner-freebsd-current@FreeBSD.ORG Tue May 30 16:04:06 2006 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4978616A881; Tue, 30 May 2006 16:04:06 +0000 (UTC) (envelope-from rodrigc@crodrigues.org) Received: from rwcrmhc13.comcast.net (rwcrmhc13.comcast.net [216.148.227.153]) by mx1.FreeBSD.org (Postfix) with ESMTP id C508443D48; Tue, 30 May 2006 16:04:05 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from c-24-147-19-128.hsd1.ma.comcast.net (c-71-233-168-2.hsd1.ma.comcast.net[71.233.168.2](misconfigured sender)) by comcast.net (rwcrmhc13) with ESMTP id <20060530160404m13009vde6e>; Tue, 30 May 2006 16:04:04 +0000 Received: from c-24-147-19-128.hsd1.ma.comcast.net (localhost [127.0.0.1]) by c-24-147-19-128.hsd1.ma.comcast.net (8.13.6/8.13.1) with ESMTP id k4UG45jK039669; Tue, 30 May 2006 12:04:05 -0400 (EDT) (envelope-from rodrigc@c-24-147-19-128.hsd1.ma.comcast.net) Received: (from rodrigc@localhost) by c-24-147-19-128.hsd1.ma.comcast.net (8.13.6/8.13.1/Submit) id k4UG451C039668; Tue, 30 May 2006 12:04:05 -0400 (EDT) (envelope-from rodrigc) Date: Tue, 30 May 2006 12:04:05 -0400 From: Craig Rodrigues To: Joe Marcus Clarke Message-ID: <20060530160405.GA39658@crodrigues.org> References: <1148962081.8820.49.camel@shumai.marcuscom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1148962081.8820.49.camel@shumai.marcuscom.com> User-Agent: Mutt/1.4.2.1i Cc: current@freebsd.org Subject: Re: -CURRENT does not recognize standard mount options X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2006 16:04:08 -0000 On Tue, May 30, 2006 at 12:08:01AM -0400, Joe Marcus Clarke wrote: > I'm trying to mount a USB stick with an MS-DOS file system on it, and > I'm specifying -o sync. This mount works in RELENG_6, and the source > for mount_msdosfs.c makes me think it should work in -CURRENT. However, > this is what I see: > > # mount_msdosfs -o sync /dev/da1s1 /mnt > mount_msdosfs: /dev/da1s1: Invalid argument Just because you could do this in RELENG_6, did -o sync actually ever work in msdosfs? There were a lot of inconsistencies in the old parsing of mount options, where UFS specific mount options would just happen to "work", i.e. "not fail" for other filesystems. Anyways, you can try this patch: Index: vfs_mount.c =================================================================== RCS file: /home/ncvs/src/sys/kern/vfs_mount.c,v retrieving revision 1.225 diff -u -u -r1.225 vfs_mount.c --- vfs_mount.c 26 May 2006 02:38:48 -0000 1.225 +++ vfs_mount.c 30 May 2006 15:59:30 -0000 @@ -139,6 +139,7 @@ "suid", "exec", "update", + "sync", NULL }; -- Craig Rodrigues rodrigc@crodrigues.org