From owner-freebsd-current@FreeBSD.ORG  Tue Jun 20 21:07:26 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1DEC816A47B;
	Tue, 20 Jun 2006 21:07:26 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2D2FC43D6E;
	Tue, 20 Jun 2006 21:07:24 +0000 (GMT) (envelope-from jhb@freebsd.org)
Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k5KL7C1s030826;
	Tue, 20 Jun 2006 17:07:12 -0400 (EDT) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Dmitry Pryanishnikov <dmitry@atlantis.dp.ua>
Date: Tue, 20 Jun 2006 17:07:04 -0400
User-Agent: KMail/1.9.1
References: <449015DE.6090407@fer.hr> <200606201002.07695.jhb@freebsd.org>
	<20060620230149.S43840@atlantis.atlantis.dp.ua>
In-Reply-To: <20060620230149.S43840@atlantis.atlantis.dp.ua>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200606201707.05938.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]);
	Tue, 20 Jun 2006 17:07:13 -0400 (EDT)
X-Virus-Scanned: ClamAV 0.87.1/1552/Tue Jun 20 16:20:09 2006 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 
	autolearn=ham version=3.1.0
X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx
Cc: kan@freebsd.org, Adi Pircalabu <apircalabu@bitdefender.com>,
	freebsd-current@freebsd.org, Hajimu UMEMOTO <ume@freebsd.org>,
	Ivan Voras <ivoras@fer.hr>
Subject: Re: Linux-flashplugin7 & rtld - RFC
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jun 2006 21:07:26 -0000

On Tuesday 20 June 2006 16:07, Dmitry Pryanishnikov wrote:
> 
> Hello!
> 
> On Tue, 20 Jun 2006, John Baldwin wrote:
> >>> This patch is somewhat redundant.  Adding
> >>>
> >>> 	__weak_reference(dlsym, _dlsym);
> >>>
> >>> is enough.
> >>
> >>   Indeed, this also works for me. It would be nice to see this trivial
> >> addition committed.
> >
> > I agree.  Do you have the __weak_reference() patch handy?
> 
>   Sure, here is the diff against HEAD:
> 
> --- libexec/rtld-elf/rtld.c.orig        Tue Mar 28 10:17:21 2006
> +++ libexec/rtld-elf/rtld.c     Tue Jun 20 22:35:17 2006
> @@ -137,6 +137,8 @@
> 
>   void r_debug_state(struct r_debug*, struct link_map*);
> 
> +__weak_reference(dlsym, _dlsym);
> +
>   /*
>    * Data declarations.
>    */
> 
> I'm not sure whether it's style(9)-compliant, it just works.

Well, this patch was shot down.  Would it be possible to have the 
pluginwrapper provide the _dlsym weak reference itself?

-- 
John Baldwin