Skip site navigation (1)Skip section navigation (2)
Date:      Sun,  9 Sep 2001 15:47:34 +0200 (CEST)
From:      Thierry Thomas <thierry@thomas.as>
To:        FreeBSD-gnats-submit@freebsd.org
Cc:        "G. Paul Ziemba" <paul@treehouse.napa.ca.us>
Subject:   ports/30455: news/newsx: fix problem when inn has tagged-hash enabled
Message-ID:  <20010909134734.7C0667767@graf.pompo.net>

next in thread | raw e-mail | index | archive | help

>Number:         30455
>Category:       ports
>Synopsis:       news/newsx: fix problem when inn has tagged-hash enabled
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 09 07:00:00 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Thierry Thomas
>Release:        FreeBSD 4.4-RC i386
>Organization:
Kabbale Eros
>Environment:
System: FreeBSD graf.pompo.net 4.4-RC FreeBSD 4.4-RC #0: Mon Aug 27 00:28:35 CEST 2001 root@graf.pompo.net:/usr/obj/mntsrc/src/sys/GRAF010429 i386


	
>Description:
	See Message-ID: <20010908015442.A13609@hairball.treehouse.napa.ca.us> on freebsd-stable.
	If inn had been built with --enable-tagged-hash, there was history
	lookups indicating that articles were already present.
>How-To-Repeat:
	make inn with --enable-tagged-hash and run newsx-1.4.
>Fix:

	Apply the following patch provided by G. Paul Ziemba:

diff -rNu news/newsx.orig/Makefile news/newsx/Makefile
--- news/newsx.orig/Makefile	Wed Aug  8 23:44:37 2001
+++ news/newsx/Makefile	Sun Sep  9 13:47:08 2001
@@ -7,6 +7,7 @@
 
 PORTNAME=	newsx
 PORTVERSION=	1.4
+PORTREVISION=	1
 CATEGORIES=	news
 MASTER_SITES=	ftp://ftp.kvaleberg.com/pub/
 
diff -rNu news/newsx.orig/files/patch-bl news/newsx/files/patch-bl
--- news/newsx.orig/files/patch-bl	Thu Jan  1 01:00:00 1970
+++ news/newsx/files/patch-bl	Sun Sep  9 14:01:25 2001
@@ -0,0 +1,34 @@
+--- src/history.c.orig	Thu Apr  8 12:56:13 1999
++++ src/history.c	Sun Sep  9 14:00:33 2001
+@@ -6,6 +6,12 @@
+  *  the GNU General Public License applies
+  *
+  *  $Log: history.c,v $
++ *
++ *  Revision x.xx  2001/09/09
++ *  patch from G. Paul Ziemba to fix the return of dbzfetch
++ *  when inn is built with tagged-hash enabled
++ *  (applied by thierry@thomas.as).
++ *
+  *  Revision 1.19  1999/04/08 10:56:13  src
+  *  *** empty log message ***
+  *
+@@ -142,6 +148,9 @@
+ 	OFFSET_T offset;
+ #  ifdef DO_TAGGED_HASH
+ 	offset = dbzfetch(key);
++	if (!offset) {	/* gpz 010907 start */
++		offset = -1;
++	}		/* gpz 010907 end */
+ #  else
+ 	idxrec ionevalue;
+ 	idxrecext iextvalue;
+@@ -161,6 +170,8 @@
+ 	    log_msg(L_DEBUGMORE,"msgid %s not in history",msgid);
+ 	    return 0;
+ 	}
++	log_msg(L_DEBUGMORE,"dbzver=6, msgid %s IS in history, off=%d",
++	    msgid, offset);
+     }
+     /* OK, we found it */
+     return 1;
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010909134734.7C0667767>