From owner-svn-ports-all@freebsd.org  Fri Apr 27 11:51:47 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7CA44FA5C05;
 Fri, 27 Apr 2018 11:51:47 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from apnoea.adamw.org (apnoea.adamw.org [104.225.5.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "apnoea.adamw.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 72056803F4;
 Fri, 27 Apr 2018 11:51:45 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id c6f4a673
 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO;
 Fri, 27 Apr 2018 05:51:43 -0600 (MDT)
Content-Type: text/plain;
	charset=utf-8;
	delsp=yes;
	format=flowed
Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\))
Subject: Re: svn commit: r468237 - in head/security/libressl: . files
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <FA98E9C4-C46E-4AA5-8B74-7F467152FE87@adamw.org>
Date: Fri, 27 Apr 2018 05:51:41 -0600
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Content-Transfer-Encoding: 8bit
Message-Id: <9F40B779-F111-45B2-8390-659BA9600224@adamw.org>
References: <201804241950.w3OJohxA009174@repo.freebsd.org>
 <FA98E9C4-C46E-4AA5-8B74-7F467152FE87@adamw.org>
To: Bernard Spil <brnrd@FreeBSD.org>
X-Mailer: Apple Mail (2.3445.6.18)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2018 11:51:47 -0000

> On 25 Apr, 2018, at 6:00, Adam Weinberger <adamw@adamw.org> wrote:
>
>> On 24 Apr, 2018, at 13:50, Bernard Spil <brnrd@FreeBSD.org> wrote:
>>
>> Author: brnrd
>> Date: Tue Apr 24 19:50:42 2018
>> New Revision: 468237
>> URL: https://svnweb.freebsd.org/changeset/ports/468237
>>
>> Log:
>>   security/libressl: Fix AES-NI assembly detection
>>
>>    - While here, fix broken man3 option
>>
>>   Reported by:	Franco Fichtner <franco opnsense org>
>
> Both these patches sound like they’ll affect the produced package.  
> Shouldn’t PORTREVISION be bumped here?
>
> # Adam

Bernard, can you respond to this please?

# Adam


--
Adam Weinberger
adamw@adamw.org
http://www.adamw.org

>> Added:
>>   head/security/libressl/files/
>>   head/security/libressl/files/patch-configure.ac   (contents, props changed)
>> Modified:
>>   head/security/libressl/Makefile
>>
>> Modified: head/security/libressl/Makefile
>> ==============================================================================
>> --- head/security/libressl/Makefile	Tue Apr 24 19:47:31 2018	(r468236)
>> +++ head/security/libressl/Makefile	Tue Apr 24 19:50:42 2018	(r468237)
>> @@ -3,7 +3,6 @@
>>
>>  PORTNAME=	libressl
>>  PORTVERSION=	2.6.4
>> -#DISTNAME=	libressl-2.6.3
>>  CATEGORIES=	security devel
>>  MASTER_SITES=	OPENBSD/LibreSSL
>>
>> @@ -27,7 +26,7 @@ CONFLICTS_INSTALL=	libressl-devel-[0-9]* \
>>  NC_CONFIGURE_ENABLE=	nc
>>
>>  GNU_CONFIGURE=	yes
>> -USES=		cpe libtool pathfix pkgconfig
>> +USES=		autoreconf cpe libtool pathfix pkgconfig
>>  USE_LDCONFIG=	yes
>>  OPTIONS_SUB=	yes
>>  CFLAGS+=	-fpic -DPIC -Wl,-rpath,${PREFIX}/lib -Wl,--as-needed
>> @@ -36,7 +35,7 @@ INSTALL_TARGET=	install-strip
>>  TEST_TARGET=	check
>>
>>  post-patch-MAN3-off:
>> -	${REINPLACE_CMD} -e 's/^install-man: install-man3/install-man:/' \
>> +	${REINPLACE_CMD} -e '/^install-man:/s/install-man3//' \
>>  		-e '/$$(MAKE) $$(AM_MAKEFLAGS) install-data-hook/d' \
>>  		${WRKSRC}/man/Makefile.in
>>
>>
>> Added: head/security/libressl/files/patch-configure.ac
>> ==============================================================================
>> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
>> +++ head/security/libressl/files/patch-configure.ac	Tue Apr 24 19:50:42  
>> 2018	(r468237)
>> @@ -0,0 +1,19 @@
>> +--- configure.ac.orig	2017-11-04 20:04:56 UTC
>> ++++ configure.ac
>> +@@ -102,13 +102,13 @@ int main() {return 0;}
>> +
>> + AC_ARG_ENABLE([asm],
>> + 	AS_HELP_STRING([--disable-asm], [Disable assembly]))
>> +-AM_CONDITIONAL([OPENSSL_NO_ASM], [test "x$enable_asm" = "xno"])
>> ++AM_CONDITIONAL([OPENSSL_NO_ASM],[test x$enableval = xno])
>> +
>> + # Conditionally enable assembly by default
>> + AM_CONDITIONAL([HOST_ASM_ELF_X86_64],
>> +-    [test "x$HOST_ABI" = "xelf" -a "$host_cpu" = "x86_64" -a  
>> "x$enable_asm" != "xno"])
>> ++    [test "x$HOST_ABI" = "xelf" -a "$host_cpu" = "x86_64," -a  
>> x$enableval != xno])
>> + AM_CONDITIONAL([HOST_ASM_MACOSX_X86_64],
>> +-    [test "x$HOST_ABI" = "xmacosx" -a "$host_cpu" = "x86_64" -a  
>> "x$enable_asm" != "xno"])
>> ++    [test "x$HOST_ABI" = "xmacosx" -a "$host_cpu" = "x86_64," -a  
>> x$enableval != xno])
>> +
>> + # Check if time_t is sized correctly
>> + AC_CHECK_SIZEOF([time_t], [time.h])