From owner-p4-projects@FreeBSD.ORG  Wed Oct 29 14:24:31 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 9DAF916A4D0; Wed, 29 Oct 2003 14:24:31 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6E9F416A4CE
	for <perforce@freebsd.org>; Wed, 29 Oct 2003 14:24:31 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id ED38743FDD
	for <perforce@freebsd.org>; Wed, 29 Oct 2003 14:24:30 -0800 (PST)
	(envelope-from sam@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.9/8.12.9) with ESMTP id h9TMOUXJ061280
	for <perforce@freebsd.org>; Wed, 29 Oct 2003 14:24:30 -0800 (PST)
	(envelope-from sam@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.9/8.12.9/Submit) id h9TMOU6U061277
	for perforce@freebsd.org; Wed, 29 Oct 2003 14:24:30 -0800 (PST)
	(envelope-from sam@freebsd.org)
Date: Wed, 29 Oct 2003 14:24:30 -0800 (PST)
Message-Id: <200310292224.h9TMOU6U061277@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	sam@freebsd.org using -f
From: Sam Leffler <sam@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 40785 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Oct 2003 22:24:32 -0000

http://perforce.freebsd.org/chv.cgi?CH=40785

Change 40785 by sam@sam_ebb on 2003/10/29 14:23:30

	correct LOR by using a local variable to hold result
	instead of holding a lock while calling out of view

Affected files ...

.. //depot/projects/netperf/sys/netinet6/in6.c#11 edit

Differences ...

==== //depot/projects/netperf/sys/netinet6/in6.c#11 (text+ko) ====

@@ -214,14 +214,16 @@
 in6_ifaddloop(struct ifaddr *ifa)
 {
 	struct rtentry *rt;
+	int need_loop;
 
 	/* If there is no loopback entry, allocate one. */
 	rt = rtalloc1(ifa->ifa_addr, 0, 0);
-	if (rt == NULL || (rt->rt_flags & RTF_HOST) == 0 ||
-	    (rt->rt_ifp->if_flags & IFF_LOOPBACK) == 0)
-		in6_ifloop_request(RTM_ADD, ifa);
+	need_loop = (rt == NULL || (rt->rt_flags & RTF_HOST) == 0 ||
+	    (rt->rt_ifp->if_flags & IFF_LOOPBACK) == 0);
 	if (rt)
 		rtfree(rt);
+	if (need_loop)
+		in6_ifloop_request(RTM_ADD, ifa);
 }
 
 /*