From owner-svn-src-all@freebsd.org Sun May 21 18:47:29 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9272BD77E2B; Sun, 21 May 2017 18:47:29 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 387351432; Sun, 21 May 2017 18:47:29 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id v4LIlNtT002130 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 21 May 2017 21:47:23 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua v4LIlNtT002130 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id v4LIlNFk002129; Sun, 21 May 2017 21:47:23 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 21 May 2017 21:47:23 +0300 From: Konstantin Belousov To: Dimitry Andric Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r318594 - in head: lib lib/libc++experimental tools/build/mk Message-ID: <20170521184723.GL1622@kib.kiev.ua> References: <201705211707.v4LH7CbN016259@repo.freebsd.org> <20170521180042.GK1622@kib.kiev.ua> <55649C56-DA8E-41C5-91B4-E72FB6A07CBC@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55649C56-DA8E-41C5-91B4-E72FB6A07CBC@FreeBSD.org> User-Agent: Mutt/1.8.2 (2017-04-18) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 May 2017 18:47:29 -0000 On Sun, May 21, 2017 at 08:34:31PM +0200, Dimitry Andric wrote: > On 21 May 2017, at 20:00, Konstantin Belousov wrote: > > > > On Sun, May 21, 2017 at 05:07:12PM +0000, Dimitry Andric wrote: > >> Author: dim > >> Date: Sun May 21 17:07:12 2017 > >> New Revision: 318594 > >> URL: https://svnweb.freebsd.org/changeset/base/318594 > >> > >> Log: > >> Add libc++experimental.a for std::experimental support > >> > >> This adds a separate library for supporting std::experimental features. > >> It is purposefully static, and must be explicitly linked into programs > >> using -lc++experimental. > >> > >> PLEASE NOTE: there is NO WARRANTY as to any stability or continuing > >> existence of the features in the std::experimental parts of the C++ > >> library! > >> > >> Reviewed by: ed > >> Differential Revision: https://reviews.freebsd.org/D10840 > >> > >> Added: > >> head/lib/libc++experimental/ > >> head/lib/libc++experimental/Makefile (contents, props changed) > >> Modified: > >> head/lib/Makefile > >> head/tools/build/mk/OptionalObsoleteFiles.inc > >> > >> Modified: head/lib/Makefile > >> ============================================================================== > >> --- head/lib/Makefile Sun May 21 15:37:08 2017 (r318593) > >> +++ head/lib/Makefile Sun May 21 17:07:12 2017 (r318594) > >> @@ -156,7 +156,7 @@ _libclang_rt= libclang_rt > >> > >> .if ${MK_LIBCPLUSPLUS} != "no" > >> _libcxxrt= libcxxrt > >> -_libcplusplus= libc++ > >> +_libcplusplus= libc++ libc++experimental > >> .endif > >> > >> SUBDIR.${MK_EFI}+= libefivar > >> > >> Added: head/lib/libc++experimental/Makefile > >> ============================================================================== > >> --- /dev/null 00:00:00 1970 (empty, because file is newly added) > >> +++ head/lib/libc++experimental/Makefile Sun May 21 17:07:12 2017 (r318594) > >> @@ -0,0 +1,29 @@ > >> +# $FreeBSD$ > >> + > >> +.include > >> + > >> +PACKAGE= clibs > >> +SRCDIR= ${SRCTOP}/contrib/libc++ > >> + > >> +LIB= c++experimental > >> +NO_PIC= > > I suspect for this case it is almost required to provide > > libc++experimental_pic.a, otherwise linking the lib to dso would > > cause textrel. > > Hmm, I don't know how to tell the build system otherwise that I don't > want any shared library. It looks like NO_PIC is needed in bsd.lib.mk > to force no .so to be built, though. > > Maybe it is easier to just build the .a file with -fPIC always? There > is really no need for two .a files. May be, indeed.