From owner-svn-src-head@FreeBSD.ORG Mon Jan 5 22:52:37 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E54D41065670; Mon, 5 Jan 2009 22:52:37 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id B15438FC23; Mon, 5 Jan 2009 22:52:37 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id n05MqXSJ049188 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 5 Jan 2009 14:52:34 -0800 (PST) (envelope-from sam@freebsd.org) Message-ID: <49628F31.5040606@freebsd.org> Date: Mon, 05 Jan 2009 14:52:33 -0800 From: Sam Leffler Organization: FreeBSD Project User-Agent: Thunderbird 2.0.0.18 (X11/20081209) MIME-Version: 1.0 To: Christoph Mallon References: <200901042153.n04LrgkD075147@svn.freebsd.org> <20090104220716.GL14235@hoeg.nl> <20090105172400.T45399@maildrop.int.zabbadoz.net> <49624DB9.8080900@gmx.de> <20090105194210.P45399@maildrop.int.zabbadoz.net> <20090105204356.GA52934@troutmask.apl.washington.edu> <49627592.60208@gmx.de> In-Reply-To: <49627592.60208@gmx.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC--Metrics: ebb.errno.com; whitelist Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, "Bjoern A. Zeeb" , src-committers@freebsd.org, Steve Kargl Subject: Re: svn commit: r186751 - in head/sys: netinet6 netipsec X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jan 2009 22:52:38 -0000 Christoph Mallon wrote: > Steve Kargl schrieb: >> Stylistic changes (including whitespace changes) are hard on >> the source repository and are to be avoided without good reason. > > Yet another anachronism in style(9). > (Does that sentence even mean what I think it means? Somehow it sounds > like "there is no good reason, but avoid them anyway" instead of > "avoid them if you have no good reason".) > > And for the N'th time I will say: style is guideline and not a contract. The day people arbitrarily change code simply because some cabal decided where spaces should go is the day people will stop contributing. It's all fine and well to make style consistent when you're working in an area of the code (and can verify your changes) but knob polishing is just code churn and in my experience is counter-productive. Spend your time and effort on fixing real problems; god knows we've got enough of 'em... Sam