From owner-freebsd-current  Wed Feb 11 12:07:23 1998
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id MAA08775
          for current-outgoing; Wed, 11 Feb 1998 12:07:23 -0800 (PST)
          (envelope-from owner-freebsd-current@FreeBSD.ORG)
Received: from implode.root.com (implode.root.com [198.145.90.17])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id MAA08763;
          Wed, 11 Feb 1998 12:07:14 -0800 (PST)
          (envelope-from root@implode.root.com)
Received: from implode.root.com (localhost [127.0.0.1])
	by implode.root.com (8.8.5/8.8.5) with ESMTP id MAA21506;
	Wed, 11 Feb 1998 12:07:12 -0800 (PST)
Message-Id: <199802112007.MAA21506@implode.root.com>
To: dyson@FreeBSD.ORG
cc: jwd@unx.sas.com (John W. DeBoskey), freebsd-current@FreeBSD.ORG
Subject: Re: Possible BUG in vfs_bio.c/brelse() line 643 
In-reply-to: Your message of "Wed, 11 Feb 1998 14:50:51 EST."
             <199802111950.OAA10458@dyson.iquest.net> 
From: David Greenman <dg@root.com>
Reply-To: dg@root.com
Date: Wed, 11 Feb 1998 12:07:12 -0800
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

>John W. DeBoskey said:
>> Hi,
>> 
>>    I believe the following is a bug in vfs_bio.c/brelse() version 1.147
>> and the following change should be committed.
>> 
>> 643c643
>> < 		if (bp->b_flags && (B_INVAL | B_RELBUF))
>> ---
>> > 		if (bp->b_flags & (B_INVAL | B_RELBUF))
>> 
>>    I always did like those if (1) conditions.
>> 
>>    Comments? Critiques?
>> 
>&& in this case is very bad.  I cannot make the change, but whomever
>has commit privs, and can do it right now, should change the && to &.

   Fixed.

-DG

David Greenman
Core-team/Principal Architect, The FreeBSD Project

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe current" in the body of the message