From owner-svn-ports-all@freebsd.org Fri Aug 21 21:46:42 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A273C9C058A; Fri, 21 Aug 2015 21:46:42 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 44E1A10D; Fri, 21 Aug 2015 21:46:42 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 260AFBDC66; Fri, 21 Aug 2015 23:45:32 +0200 (CEST) Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205]) by prod2.absolight.net (Postfix) with ESMTPA id 04F22BDC56; Fri, 21 Aug 2015 23:45:32 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by atuin.in.mat.cc (Postfix) with ESMTP id BD5D241425DE; Fri, 21 Aug 2015 23:45:31 +0200 (CEST) Date: Fri, 21 Aug 2015 23:45:31 +0100 From: Mathieu Arnold To: Alexey Dokuchaev , Dmitry Marakasov cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r394970 - head/devel/love07 Message-ID: <1401876A0D871EB1944F20BC@atuin.in.mat.cc> In-Reply-To: <20150821185335.GA86849@FreeBSD.org> References: <201508211600.t7LG05HP050267@repo.freebsd.org> <20150821171523.GA49960@FreeBSD.org> <20150821172406.GA41937@hades.panopticon> <20150821185335.GA86849@FreeBSD.org> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="==========6E469940F1E2850A7CC5==========" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Aug 2015 21:46:42 -0000 --==========6E469940F1E2850A7CC5========== Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline +--On 21 ao=C3=BBt 2015 18:53:36 +0000 Alexey Dokuchaev wrote: | After we entered staging era, we started to get rid of .if ${PORTDOCS} | checks because we could use the benefit of dumping everything possible = [1] No. Dropping the .if ${PORT_OPTIONS:MDOCS} checks was to avoid getting hit by having to include bsd.port.options.mk, which includes bsd.port.mk, and thus, make had to parse it twice (once from bsd.port.options.mk, once at the end of the Makefile), which takes time. So, we started installing docs files in post-install when there was "not too much of them", installing them inconditionnaly was supposed to be a less hit than parsing bsd.port.mk twice. I added target options helpers (and rewrote the target ordering mechanism on the way), so we still do not need bsd.port.options.mk to check for PORT_OPTIONS:MDOCS/EXAMPLES/WHATEVEROPT, saving us from parsing bsd.port.mk twice, but now, only installing the files when they're needed, and not always. --=20 Mathieu Arnold --==========6E469940F1E2850A7CC5========== Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQJ8BAEBCgBmBQJV15v7XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85ILhoP/2uua0qCJ8SmkEHkKBn1BW3j yAA+Icdsr//k9d0hYB6okLyhnmKAZPAQjUHjVlRF4LXTV9BEdA5MlVb22bMaE46L aRkWuoLnWwWYHtggTmNKXTzP6XPS6rvIGOJhjYolQAyRXpqFizwgqZsEA1eml7xH 6aIKN91kcSeMRR3jaafg1ouyLEmNWOUPqvmTCd0ZOY1+6RGCA5VXi96zMk3EDgXX pngyyQCvpLbADnGKI/IrCAoCo1qz2hT9l6N0imVfbEupTvDJP/4CEF+KAsN80A2i 8OjuAEt2X85BJCyctIOuJ804MdMEt9YeYib46HJlSU6j6Rnt8nZHN+CbFQA0ZCgu wRDIs3obZ5/6sB/qOP7V5psb16fxkqXZUpGg47GeT+abBoHzp3gMVk8xrdLv4uXM /VgIYyiSQyvxhgLIbbqazt1a5Bw8ulUTnaZ3alXN8YhQzyKl+R+GktqKUpkQlTLA iqIXb3r2xzTCTx/eiu4v62T5WcbDhcxT6LgsWf7jewH9ZRcZqOrRAOfBGTN/U888 Lg0vEpCW6o9oQ4h8JXVdYerVMzeTxxxgjwwbISl9caim2vTRulQEsQFQbAin16Bw pxsJvK0gnJIbp5NmKyz9UlzhkCsN5QGy+ZtwtS27UhHyPbPW5qerNKOi7nikw7fn KYZBYrJhOG5rC9NeZ4fC =Ps3L -----END PGP SIGNATURE----- --==========6E469940F1E2850A7CC5==========--