Date: Fri, 13 Apr 2018 17:01:28 +0200 From: Jochen Neumeister <joneum@FreeBSD.org> To: Joseph Mingrone <jrm@FreeBSD.org>, Matthias Fechner <idefix@fechner.net> Cc: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org>, Torsten Zuehlsdorff <freebsd@toco-domains.de>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r467193 - in head/www/gitlab: . files Message-ID: <e6417f5a-5379-344b-357d-0b2f75bcf980@FreeBSD.org> In-Reply-To: <86o9inrzzk.fsf@phe.ftfl.ca> References: <201804121833.w3CIXtgW077267@repo.freebsd.org> <e1a55c7b-1ad1-36c8-ec3d-f806702feed5@fechner.net> <CAMHz58RD9rtyqBLV6nsZ2naOvGRiO7PDPAGWZ8Vemnz-g1J6cw@mail.gmail.com> <431aaec9-51c2-c0c9-7a1f-2f29f79edb5d@fechner.net> <20180413100736.GA32041@FreeBSD.org> <b14f8ea5-5d26-6ea0-c175-558a8fef2504@toco-domains.de> <86o9inrzzk.fsf@phe.ftfl.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13.04.2018 15:35, Joseph Mingrone wrote: > Matthias Fechner <idefix@fechner.net> writes: >> Dear sunpoet, >> Am 12.04.2018 um 20:33 schrieb Sunpoet Po-Chuan Hsieh: >>> Log: >>> Fix Gemfile for rubygem-default_value_for 3.1.0 update >>> - Bump PORTREVISION for package change >>> Modified: >>> head/www/gitlab/Makefile >>> head/www/gitlab/files/patch-Gemfile >> I really enjoy your work and it is totally fine for me, if you upgrade a >> gem that you copy the old one and make sure that gitlab uses the old. >> (like you did with r467106, thanks a lot for this!) >> But please do not start to patch the Gemfile! >> This will break gitlab. Have you tested gitlab with this modification? >> (for sure not, I reported exactly that version of default_value_for >> upstream and they rolled back the change as it broke gitlab, they broke >> 3.0.4 and rolled back the modification with 3.0.5, now you changed >> gitlab to use the version that for sure will not work!) >> Please revert this modification and ask me (the maintainer) before you >> start to modify the port I maintain. >> Thanks a lot that you understand this. >> Gruß >> Matthias > I relate. Sunpoet, I also appreciate your work, but this type of > breakage can be frustrating. We need to figure out a solution. > +1 Unfortunately sunpoet does not always react when it draws attention to errors. Funny: he complained about the mistake myself last year. It needs a solution to better respect the work of others. joneum
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e6417f5a-5379-344b-357d-0b2f75bcf980>