Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 22 May 2009 23:33:47 +0300
From:      Kostik Belousov <kostikbel@gmail.com>
To:        John Baldwin <jhb@freebsd.org>
Cc:        src-committers@freebsd.org, Kip Macy <kmacy@freebsd.org>, svn-src-stable@freebsd.org, svn-src-all@freebsd.org, svn-src-stable-7@freebsd.org, rwatson@freebsd.org, Dimitry Andric <dimitry@andric.com>
Subject:   Re: svn commit: r192590 - stable/7/sys/sys
Message-ID:  <20090522203347.GE1927@deviant.kiev.zoral.com.ua>
In-Reply-To: <200905221621.15507.jhb@freebsd.org>
References:  <200905221754.n4MHs3cr014003@svn.freebsd.org> <200905221507.39476.jhb@freebsd.org> <4A17063F.60303@andric.com> <200905221621.15507.jhb@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--67nA0I2t09EExhkH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 22, 2009 at 04:21:14PM -0400, John Baldwin wrote:
> On Friday 22 May 2009 4:08:31 pm Dimitry Andric wrote:
> > On 2009-05-22 21:07, John Baldwin wrote:
> > >> Log:
> > >>   some ports erroneously use the existence of AT_FDCWD to check for
> > >>   the availability of the *at system calls so s/AT_FDCWD/AT_FDCWD_no=
tyet/g
> > >>  =20
> > >>   Reported by: Dimitry Andric
> > >=20
> > > I wonder if it wouldn't be appropriate to just remove the dirfd bits =
entirely=20
> > > from 7.x for now.  I.e. remove NDINIT_AT(), AT_FDCWD_notyet, the 'dir=
fd'=20
> > > member from the structure, the 'dirfd' parameter from NDINIT_ALL(), e=
tc.  ZFS=20
> > > only really needed NDINIT_ATVP(), yes?
> >=20
> > Are there any plans to MFC the *at() calls?  (I'd guess not, since it
> > looks like they change the ABI...)=20
>=20
> I don't think there are due to the ABI change, and if they were ever MFC'=
d,
> the NDINIT, etc. bits could be restored as part of that merge.
No, the MFC is posponed not due to KBI change. As I said, I already have
a permission from re@ to change nameidata.

Robert (Cc:ed) hold the MFC because the new fd argument of the at syscalls
is not audited.

--67nA0I2t09EExhkH
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)

iEYEARECAAYFAkoXDCsACgkQC3+MBN1Mb4iemQCgnKiBcPEO9Ejqk0Nsi6RqbPBJ
3wkAoJbE3I9Njsi+XJ1s82uAXM5n2r7s
=O2pJ
-----END PGP SIGNATURE-----

--67nA0I2t09EExhkH--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090522203347.GE1927>