From owner-freebsd-bugs@freebsd.org Thu Aug 6 16:42:34 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B723A3A6C01 for ; Thu, 6 Aug 2020 16:42:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4BMvRZ4VLGz4KsB for ; Thu, 6 Aug 2020 16:42:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 9833D3A6C00; Thu, 6 Aug 2020 16:42:34 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 96EDE3A6AD1 for ; Thu, 6 Aug 2020 16:42:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BMvRZ3PRGz4Ks9 for ; Thu, 6 Aug 2020 16:42:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 58115A199 for ; Thu, 6 Aug 2020 16:42:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 076GgYgG080649 for ; Thu, 6 Aug 2020 16:42:34 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 076GgYNS080648 for bugs@FreeBSD.org; Thu, 6 Aug 2020 16:42:34 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 248502] Running multiple concurrent instances of freebsd-update(8) cause weird errors Date: Thu, 06 Aug 2020 16:42:34 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 12.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: moviuro+freebsd@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Aug 2020 16:42:34 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D248502 Bug ID: 248502 Summary: Running multiple concurrent instances of freebsd-update(8) cause weird errors Product: Base System Version: 12.1-STABLE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: moviuro+freebsd@gmail.com I tried using freebsd-update(8) at once to update both my system (on /) and= my basejail. It did not end well. =C2=A0 # freebsd-update fetch =C2=A0 # freebsd-update -b /usr/jails/basejails/12.1_amd64 fetch # at the s= ame time This will cause lots of weird errors (but it didn't actually break anything, which is a relief): * Checksum mismatch * Missing files (patchlist, files.wanted, filelist) * Patch count errors (was that 21 patches? or 278?) * etc. Expected behavior: * Either fail "another instance of freebsd-update(8) is running in workdir: [...] Remove the lockfile (/path) if you're sure about it." * Or gracefully handle multiple concurrent freebsd-update(8) by using a specific subdirectory in workdir (e.g. /var/db/freebsd-update/Lw=3D=3D and L3Vzci9qYWlscy9iYXNlamFpbHMvMTIuMV9hbWQ2NA=3D=3D, respectively - just a bas= e64 encode of the basedir) https://github.com/freebsd/freebsd/blob/6b0fd688d5fee8dfd4e0a28ae52741be85d= c80ea/usr.sbin/freebsd-update/freebsd-update.sh#L137-L143 https://github.com/freebsd/freebsd/blob/6b0fd688d5fee8dfd4e0a28ae52741be85d= c80ea/usr.sbin/freebsd-update/freebsd-update.sh#L1139-L1142 --=20 You are receiving this mail because: You are the assignee for the bug.=