Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 20 Feb 2008 11:30:00 -0800 (PST)
From:      Matthew Jacob <mj@feral.com>
To:        scsi@freebsd.org
Subject:   scsi_ses.c fixes
Message-ID:  <20080220112921.Y20235@ns1.feral.com>

next in thread | raw e-mail | index | archive | help

I guess nobody uses SES that much. Instant panics here.

Index: scsi_ses.c
===================================================================
RCS file: /home/ncvs/src/sys/cam/scsi/scsi_ses.c,v
retrieving revision 1.35
diff -u -r1.35 scsi_ses.c
--- scsi_ses.c	16 May 2007 16:54:23 -0000	1.35
+++ scsi_ses.c	20 Feb 2008 19:08:33 -0000
@@ -516,7 +516,7 @@
  		cam_periph_unlock(periph);
  		return (ENXIO);
  	}
-	cam_periph_lock(periph);
+	cam_periph_unlock(periph);

  	error = 0;

@@ -555,14 +555,14 @@
  			obj.obj_id = i;
  			obj.subencid = ssc->ses_objmap[i].subenclosure;
  			obj.object_type = ssc->ses_objmap[i].enctype;
-			cam_periph_lock(periph);
+			cam_periph_unlock(periph);
  			error = copyout(&obj, uobj, sizeof (ses_object));
  			cam_periph_lock(periph);
  			if (error) {
  				break;
  			}
  		}
-		cam_periph_lock(periph);
+		cam_periph_unlock(periph);
  		break;

  	case SESIOC_GETENCSTAT:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080220112921.Y20235>