From owner-svn-ports-all@FreeBSD.ORG Fri Apr 25 09:47:45 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 75F175A8; Fri, 25 Apr 2014 09:47:45 +0000 (UTC) Received: from mail-wi0-x230.google.com (mail-wi0-x230.google.com [IPv6:2a00:1450:400c:c05::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8CED01A2C; Fri, 25 Apr 2014 09:47:44 +0000 (UTC) Received: by mail-wi0-f176.google.com with SMTP id r20so2387684wiv.3 for ; Fri, 25 Apr 2014 02:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=lrnLtCVurfaWOKcgORRSonH8/U6I8RHn1VJRE0vvdbA=; b=BT5DYdzoxOlqYPvrgD9MvijJ9SNILQDlQ73nRCPlRuoBUcnwt+VLHy2OT+ysf2qcEq s6q1TaMH9aEUgtS89PcLEh0tWl7ogt75olZpaJ4ahDLgqRiXXOF/A11hLtvLTYD+8LkV yQhSvYdoguxcV8r+h8gvlal5wZocjZbYE4iUlWefhTESN/hr3zUYmPAD7fI3koCZzVKi 5+Ary0vAWYKQc+kOC66W4Zyvd0u/rr1tHVoNbKLNP/1GZDANgnDrcH0ol7GFL9aG36Vw f6/OA+8w9FcKTpeo2wxFAIl4lAn91VcbD/0e/AIFl+jf0mv8yPxIefj3L4kWgN1cL//k 94jw== X-Received: by 10.194.82.9 with SMTP id e9mr5822621wjy.45.1398419262841; Fri, 25 Apr 2014 02:47:42 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id cj9sm4817168wid.1.2014.04.25.02.47.41 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Apr 2014 02:47:41 -0700 (PDT) Sender: Baptiste Daroussin Date: Fri, 25 Apr 2014 11:47:39 +0200 From: Baptiste Daroussin To: Tijl Coosemans Subject: Re: svn commit: r352093 - head/x11/startup-notification Message-ID: <20140425094739.GC38988@ivaldir.etoilebsd.net> References: <201404250738.s3P7c2CV097634@svn.freebsd.org> <20140425111327.3e351b84@kalimero.tijl.coosemans.org> <20140425092011.GB38988@ivaldir.etoilebsd.net> <20140425114227.37f2c3db@kalimero.tijl.coosemans.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="da4uJneut+ArUgXk" Content-Disposition: inline In-Reply-To: <20140425114227.37f2c3db@kalimero.tijl.coosemans.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Apr 2014 09:47:45 -0000 --da4uJneut+ArUgXk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 25, 2014 at 11:42:27AM +0200, Tijl Coosemans wrote: > On Fri, 25 Apr 2014 11:20:12 +0200 Baptiste Daroussin wrote: > > On Fri, Apr 25, 2014 at 11:13:27AM +0200, Tijl Coosemans wrote: > >> On Fri, 25 Apr 2014 07:38:02 +0000 (UTC) Baptiste Daroussin wrote: > >>> Modified: head/x11/startup-notification/pkg-plist > >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >>> --- head/x11/startup-notification/pkg-plist Fri Apr 25 07:34:14 2014 = (r352092) > >>> +++ head/x11/startup-notification/pkg-plist Fri Apr 25 07:38:01 2014 = (r352093) > >>> @@ -5,9 +5,9 @@ include/startup-notification-1.0/libsn/s > >>> include/startup-notification-1.0/libsn/sn-util.h > >>> include/startup-notification-1.0/libsn/sn.h > >>> lib/libstartup-notification-1.a > >>> -lib/libstartup-notification-1.la > >>> lib/libstartup-notification-1.so > >>> lib/libstartup-notification-1.so.0 > >>> +lib/libstartup-notification-1.so.0.0.0 > >>> libdata/pkgconfig/libstartup-notification-1.0.pc > >>> @dirrm include/startup-notification-1.0/libsn > >>> @dirrm include/startup-notification-1.0 > >>=20 > >> It's probably better to use libtool:keepla here. There are too many > >> ports that depend on this port with .la files that may refer to > >> libstartup-notification-1.la. > >>=20 > >> I've been thinking if it would be possible for pkg to register .la fil= es > >> (and their references to other libraries) like it does with .so files. > >> Then you could find out if there are references lurking in other ports > >> with pkg rquery. > >=20 > > Concerning gnome related ports like this one I'm pretty confident about= removing > > the .la as upstream jhbuild continuous integration system expect everyt= hing to > > be install without .la, so almost nothing should expect to find the .la= here. >=20 > The problem is that it was previously there so other .la files now contain > references to it. For instance on my xfce system: >=20 > % grep -Rl libstartup-notification-1.la /usr/local/lib/* > /usr/local/lib/libstartup-notification-1.la > /usr/local/lib/libwnck-1.la > /usr/local/lib/libxfce4kbd-private-2.la > /usr/local/lib/libxfce4ui-1.la > /usr/local/lib/libxfsm-4.6.la > /usr/local/lib/thunarx-2/thunar-uca.la > /usr/local/lib/xfce4/panel/plugins/libactions.la > /usr/local/lib/xfce4/panel/plugins/libapplicationsmenu.la > /usr/local/lib/xfce4/panel/plugins/libclock.la > /usr/local/lib/xfce4/panel/plugins/libdirectorymenu.la > /usr/local/lib/xfce4/panel/plugins/liblauncher.la > /usr/local/lib/xfce4/panel/plugins/libpager.la > /usr/local/lib/xfce4/panel/plugins/libseparator.la > /usr/local/lib/xfce4/panel/plugins/libshowdesktop.la > /usr/local/lib/xfce4/panel/plugins/libsystray.la > /usr/local/lib/xfce4/panel/plugins/libtasklist.la > /usr/local/lib/xfce4/panel/plugins/libwindowmenu.la > /usr/local/lib/xfce4/panel/plugins/libclipman.la > /usr/local/lib/xfce4/panel/plugins/libxfce4dict.la > /usr/local/lib/xfce4/session/splash-engines/libbalou.la > /usr/local/lib/xfce4/session/splash-engines/libmice.la > /usr/local/lib/xfce4/session/splash-engines/libsimple.la >=20 > The problem is that when I update x11/startup-notification now these > references go stale. If I then update a port that links with libwnck-1.la > for instance using libtool, that will be broken because libtool cannot > find libstartup-notification-1.la. I haven't tought about this case (only inpacting people live building not b= inary package and that an exp-run cannot find) Ok I'll add :keepla >=20 > > concerning registering the .la that will be quite complicated because a= s far as > > I know, no trace of .la is left inside the resulted binaries, but if yo= u think > > about a clever way, I'm not against it :) >=20 > No, you need to scan the .la files itself just like you scan .so files. > Think of an .la file as a library on its own. A package can provide .la > files and it can have other .la files as dependencies. We're trying to > get rid of these .la dependencies, but it would be nice to have a way to > detect them. Ah right I'll see what I can do regards, Bapt --da4uJneut+ArUgXk Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlNaLzsACgkQ8kTtMUmk6EwqggCgjLV3AiwOoX+CjDsdRNMqVDmf /+oAnimpGCG464NXR5du0vXEVXHuny55 =UJ+G -----END PGP SIGNATURE----- --da4uJneut+ArUgXk--