From owner-freebsd-current  Sun Jul 16 21:36:26 1995
Return-Path: current-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id VAA27997
          for current-outgoing; Sun, 16 Jul 1995 21:36:26 -0700
Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id VAA27990
          for <current@freebsd.org>; Sun, 16 Jul 1995 21:36:22 -0700
Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id VAA00381 for current@freebsd.org; Sun, 16 Jul 1995 21:36:53 -0700
From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>
Message-Id: <199507170436.VAA00381@gndrsh.aac.dev.com>
Subject: patch for /usr/src/usr.sbin/ppp/chat.c (fwd)
To: current@freebsd.org
Date: Sun, 16 Jul 1995 21:36:53 -0700 (PDT)
X-Mailer: ELM [version 2.4 PL24]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Length: 1439      
Sender: current-owner@freebsd.org
Precedence: bulk

This patch has been reviewed by me, and looks good for
inclusion.  I would like the ppp folks to look at it
and incorporate it as well as feed it back to the ppp
maintainers.

Thanks,
Rod Grimes

Forwarded message:
> From rich@lamprey.utmb.edu Sun Jul 16 21:00:41 1995
> Date: Sun, 16 Jul 1995 22:59:59 -0500
> From: Rich Murphey <rich@lamprey.utmb.edu>
> Message-Id: <199507170359.WAA03793@id.slip.bcm.tmc.edu>
> To: rgrimes@gndrsh.aac.dev.com
> Subject: patch for /usr/src/usr.sbin/ppp/chat.c
> Return-Receipt-To: rich@lamprey.utmb.edu
> Reply-to: rich@lamprey.utmb.edu
> 
> 
> I'm a little uneasy about having the user-level-ppp daemon
> echo your password to /usr/log/ppp.log.  Here's a patch that
> logs the token that represents the password (\P) rather than
> the password itself.  Rich
> 
> 
> --- chat.c.dist	Tue May 30 06:21:52 1995
> +++ chat.c	Sun Jul 16 22:56:17 1995
> @@ -373,7 +373,11 @@
>      } else {
>        (void) ExpandString(str, buff+2, 1);
>      }
> +    if (strchr(str, "\P")) {	/* Do not log the password itself. */
> +      LogPrintf(LOG_CHAT, "sending: %s\n", str);
> +    } else {
>      LogPrintf(LOG_CHAT, "sending: %s\n", buff+2);
> +    }
>      cp = buff;
>      if (DEV_IS_SYNC)
>        bcopy("\377\003", buff, 2);	/* Prepend HDLC header */
> 


-- 
Rod Grimes                                      rgrimes@gndrsh.aac.dev.com
Accurate Automation Company                 Reliable computers for FreeBSD