From owner-freebsd-current@freebsd.org Thu Oct 17 21:29:40 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 12A9015E0A1 for ; Thu, 17 Oct 2019 21:29:40 +0000 (UTC) (envelope-from ltning@anduin.net) Received: from mail.modirum.com (mail.modirum.com [185.42.170.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46vMkW1GX9z3GQf for ; Thu, 17 Oct 2019 21:29:38 +0000 (UTC) (envelope-from ltning@anduin.net) Received: by mail.modirum.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2 (FreeBSD)) (envelope-from ) id 1iLDKx-000Gg4-W8 for freebsd-current@freebsd.org; Thu, 17 Oct 2019 21:29:36 +0000 Subject: Re: DRM-current-kmod is still a problem at r353339 To: freebsd-current@freebsd.org References: <7ca3b30a-81f6-f79d-1486-7fd29765646f@acm.org> <99c89ca0-462c-f4c7-fa07-6f61e9d39d66@acm.org> <3bb2e410-51dd-bc3f-7660-41a4683551b3@daemonic.se> <20191017195347.GB6447@raichu> <53ff1ac5-c7e8-1b6c-bd43-481eaef61120@daemonic.se> From: =?UTF-8?Q?Eirik_=c3=98verby?= Autocrypt: addr=ltning@anduin.net; keydata= mQGiBER75WwRBACP+1m6g/QUwH3CsJFpfQy50U3bRWaLrpCg+p4jzheLE9l5yfqT7bqPQt/w IXUFjpSEtEMqHxBoKXCLaVW56i74zobFPda3Msj7SwFvUI4oo4N1HVquS/PbjiMfn0sTb9wO YHNza2Q+qxhq9Vk6uyjCq3Q0iYouDz2nZNtnP7023wCgoWbGucQyzxm0i//GaICKf/2TFPUD /2PCaia5BXL9YKI/s8gVHKnUQuaHun6eDmhdiiZ4kdzCnwmBVKogChy0iglH8PmyNww0CW+1 VKTzTXVlqWH78QcNMUYW6wzmyBWK+1zgfasJdrcK+9/23//p4JVlJgnX9l6YixZr/hs9Oj3C RtFkuJ377sNP7XdwSyeITd26indwA/oCeBvVoHW34NGaT1FfI8tjHHhUsNpel3zDaiHEjCcT SffB/zQuLgGZU+bJ+nBIPqrzJ2LwVEJf1gmfysUUQN3ubP44m/dMUxDyHfR1XJfoc1j/H9YH 8H8L8I98l34TTBdVVJBPfsUhERDtfxumfsAoXe1OJC0MxLGVQYUnMZKRCLQhRWlyaWsgT2V2 ZXJieSA8bHRuaW5nQGFuZHVpbi5uZXQ+iGEEExECACECGwMGCwkIBwMCAxUCAwMWAgECHgEC F4AFAkeLFlECGQEACgkQDRlfnc8VQWeAhACfYOl14JOJtcmYehWVARL7pEl7CCQAn1V0AXc4 1mfCGrT4unheqtvuRi0suQQNBER75cUQEAClD2IXaoBElcXYBRBHduoWR+RH3kQT9oYH2F0l FuSpaWbhFxKS8WmIz2dwyDvvz+yBNIyftiIssE7i8CduWH9h/hcKAm1IhhEyb8otcOBnWz38 u6QRBVk5H7dGLelwm9X4HKR1/lWhetyB0FBDAvVKleaQZzPKnSL5FerU5nJy36IINWlJ27cN nZ0kbs2O6VMdqlAWob/R+Ygr1zYFxdV4Dy69rxDj0sezdtIYWkCbQg1EzQMnzOsEWcAnnQzX lVMCFCldWBaGEU/E5T82GG6LGUtUhj5R9eAh4cDXcaJkamkJIU1LvFyfQ9J8vmJvabsQbGBe dsI/2r/4cZfYYqWe2JOliRIBonPUNlydZuDVjPd2sL5se5wICZzlFajU2FdKGflCtiB92kSy BQ1Ng26RIx4ZcQE7hEZ2XO9p3fBwZ/tEYdeJ4CdXuZqctPLvVn0JpskO8G86aM+WgCAFUrGB QBL39ouP6wyAKaY/vRNyK0oKRDIu4J0n1KrJupspideY61yuFBK6mZUBctdEdivr5yZy6zak OfANvS9Q4ll+aaVy4dsZ5IVSTE5aFP5vQOBWwBN8g81NtrzwWP1jkNfYvo6jA/rIsvHA5GLf GFwDEaLOSoPYdFx5YG952zW9we/190HeO58zMCyKv57DuGdt1FlVCiH0eQN36PkwgzqR+wAD Bg/+Pr4yjhcJrG/umxFk0NIQ/clpiJ6OXsspiFH9PgJ0EQpYVW814lDEHEjPeIuw8QHGeumB mIMBDQ9Y01iyaxFFtD6JkvF5YFL+ajRmIkHlYutI08+IK9FutskCQDSxwbcV6frE5u1mFcZn LnajCR872F52qVKac+X+bVFScscw3iwBPvO6By2UIhfnqw7CyWEVic8C1uCMpPxJDzvU8mXO NGGm+5QrX8Mz/IrPqKeCRYCAi04nsYoWjdL6l6KCY/Y5i0r8rhOSpxQGQtPVYFxiz98snAV5 nsDY/8dMIq4oY0qrOR1soIMA15M/wVFIp32ybj7TsDqT5MboAdlPUeWO2r4DSWQq4+QufiKG uVEBxQLTBm+mqAgyeQFucBHVdy45nDqlo9mANu9USPaJZWpo+j+GW3am3tGawaUr5MTTZZIQ GY0XvlI5XrsnfWhzCZ/ntC6HoepixHlteuhlbsI/awemMDBpfIpcEymWxT7U1SKf3kflbqjQ jOJosdRATaKwQidw56pka0FtnFePlXk5UVaZUFA2REcr7jUZfqUJe+6/z3YOO+/tQuANa+Ba FvJGpyBkVnNwF80nz65eSQAkGxd9GwsTcmb8XBoEp8uDG/QzpYY71N0eb761ycdAZ6BwnPYd ih8pbczRcdIFopv03mqV/bUD+MOVLBLKG80UwXiISQQYEQIACQUCRHvlxQIbDAAKCRANGV+d zxVBZ+m0AJ9ejou5ID3iQhtKSecwm/Lh3776lACgm30erYDruurUMGCkKD2fW1JEvBw= Message-ID: Date: Thu, 17 Oct 2019 23:29:35 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <53ff1ac5-c7e8-1b6c-bd43-481eaef61120@daemonic.se> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-SA-Authenticated: Yes X-Rspamd-Queue-Id: 46vMkW1GX9z3GQf X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of ltning@anduin.net designates 185.42.170.44 as permitted sender) smtp.mailfrom=ltning@anduin.net X-Spamd-Result: default: False [-2.30 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.995,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[anduin.net]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE(-0.00)[country: NO(-0.01)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:62248, ipnet:185.42.170.0/24, country:NO]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Oct 2019 21:29:40 -0000 On 10/17/19 10:31 PM, Niclas Zeising wrote: > On 2019-10-17 21:53, markj@freebsd.org wrote: >> On Thu, Oct 17, 2019 at 03:03:51PM +0200, Niclas Zeising wrote: >>> On 2019-10-16 18:57, Neel Chauhan wrote: >>>> While drm-current-kmod worked for a little while, it broke with r353645. >>>> >>>> https://i.imgur.com/Q5nYZf2.jpg >>>> >>>> I'm using the same HP Spectre that I used earlier (where it worked and >>>> where it panicked). >>>> >>> >>> That commit looks unrelated, it touches the wbwd and superio drivers, >>> nothing else.  Any chance you can bisect exactly which revision that >>> caused the new issues? >> >> I believe it was the recent work on the vm page busy state, r353539 >> specifically.  This patch should fix it; we don't yet have a >> __FreeBSD_version number bump on which to gate the patch. >> >> diff --git a/linuxkpi/gplv2/src/linux_page.c b/linuxkpi/gplv2/src/linux_page.c >> index e2b85c45c..060ae85ed 100644 >> --- a/linuxkpi/gplv2/src/linux_page.c >> +++ b/linuxkpi/gplv2/src/linux_page.c >> @@ -239,7 +239,7 @@ retry: >>               page = vm_page_lookup(devobj, i); >>               if (page == NULL) >>                   continue; >> -            if (vm_page_sleep_if_busy(page, "linuxkpi")) >> +            if (!vm_page_busy_acquire(page, VM_ALLOC_WAITFAIL)) >>                   goto retry; >>               cdev_pager_free_page(devobj, page); >>           } > > Hi! > Hopefully someone can confirm that this patch to drm-current-kmod or drm-devel-kmod fixes the issue.  I won't be able to work on this before the weekend at the earliest, I'm afraid. > Mark, is it possible to get a belated version bump for this fix, and what changed to require it? Built, rebooting ... Will hopefully check back in soon. /Eirik