From owner-svn-src-head@freebsd.org Mon May 18 20:48:18 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EFCA12DD34D for ; Mon, 18 May 2020 20:48:18 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from 44-233-67-66-mail.ore.mailhop.org (44-233-67-66-mail.ore.mailhop.org [44.233.67.66]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49Qrh238LZz4L5h for ; Mon, 18 May 2020 20:48:18 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1589834891; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=Dcyv6QRdKP1lhYHxuZ9ebei0B+2eZNgBvsQP+w7S1lD/Ur5a6F51zybC0fTREcLqrtFjz+P1YA/z6 CbcwTuB2uKPyPfAb5uqCcpmQQU4in/VgtN/l82v17G9SzgScaIm49KI595q2q1p76wGYdF8E8D96Ab WwUayx3wI7mys0ABj1MOjrNRaTQT4lTQcpapOZoAz8hp4+T94tPm/IBUuQ9hwBTLlHaa7Owmh96nrH fV51zmJ2vHwiGB3pXb4zatmVlRlCSyWQ4BDg1kC/X53ldLT1AgsxlNZHPx+BKbnPrFPt2ybmpLp4PS zlgoN0lBNVTfcDlaSrv1Da2Lo+XmWsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=JJeT2QWE78kcllOuHXm5k4PCPYPZc5qZfhiUEkKlYB0=; b=S+ajCtmts8upMBxXSunNiO+I56EirmX5y4kU8HEvfDET6llBI3VZ50+taVb30RS7GDoIpmEmlxBWn tXdnMbhTMvOOw2yD0ENc2kfY5NiXHsH4sOIHSe2dRL+F5EQNJaDaIHY3+OaVYygFIlqVY0dhBrHDNu 4uyp3KuSxH+4r7QWCTW3R+Ibe7LdEv1+j2rLejF4iFON/vhEqBeirFqN5JEoSsWVmiFwxX2tcEC0u/ zPTBamkbfALlYBAxPyKpxxti5YkxVtg9cYxjC+CuhPZWFgnSYDUdkhgJRmdUpCMLhPhtdZBO6BL2DN GRyAq9Jnb1LjdIm3uq2MfseEuMyoUkQ== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=JJeT2QWE78kcllOuHXm5k4PCPYPZc5qZfhiUEkKlYB0=; b=hmKuZSF7Y/WF5sXoqG2icxEMcUsC6iIuMMCSzo51qsegcNwCQxesPrOAQTlVU2s9yhh8P6hYnOdi6 W8ja/5o0ue7Wqw3CrWiFEiB/H1JMiRravFIWRWC9c95exUMYSb44KpN2WpOFE8KtVfA4HR3ATtRGnN Yq0i0raHO9JpG4Zie/8e8ykJvfFnTafJ0T1Bi2i+/w+QeBagD63HqxzUQZYLrQN/32efrEElgNNsMi hxb4IdAJVhVMBMKLPbDlim9t2UyFLBG1DAk32Lf93ax0S7pKWB0ny1eyynF9M3iW19KVZBFh163FA5 OpelbLPXnG+UTyBAkzmA8k0k3F0n1Hg== X-MHO-RoutePath: aGlwcGll X-MHO-User: e1d5a179-9948-11ea-b10c-b5956a7dd1a1 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (c-67-177-211-60.hsd1.co.comcast.net [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id e1d5a179-9948-11ea-b10c-b5956a7dd1a1; Mon, 18 May 2020 20:48:10 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 04IKm9KK003227; Mon, 18 May 2020 14:48:09 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <124078163fc75e82a0acaff85f57859d012c6d98.camel@freebsd.org> Subject: Re: svn commit: r361209 - head/sys/netinet From: Ian Lepore To: Michael Tuexen , cem@freebsd.org Cc: src-committers , svn-src-all , svn-src-head Date: Mon, 18 May 2020 14:48:09 -0600 In-Reply-To: References: <202005181007.04IA713t089936@repo.freebsd.org> <064C2DCD-6279-4442-A900-0ECCD50CC4FA@freebsd.org> Content-Type: text/plain; charset="ASCII" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 49Qrh238LZz4L5h X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[freebsd.org]; ASN(0.00)[asn:16509, ipnet:44.224.0.0/11, country:US] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 May 2020 20:48:19 -0000 On Mon, 2020-05-18 at 22:43 +0200, Michael Tuexen wrote: > > Sure. You can certainly ignore user reports corresponding to bogus > > flags, though, and encourage use of various flags. > > I could, but decided to improve the situation for some people, but > wasn't realising that I made it worse for others. Sorry about that. I'm trying to figure out why your original commit was a problem. I understand why it was questioned, but once the answer came out, it's clear that the code you originally committed does what it's supposed to without any harmful side effects. Sure, freebsd doesn't strictly need it, but the code is shared among projects, so what's the harm in the extra check that helps other projects sharing the code? It's certainly a lot less confusion and code clutter than any of the "remedies" that have been discussed. -- Ian