From owner-dev-commits-src-main@freebsd.org Wed Apr 7 08:37:45 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7B3245CF929; Wed, 7 Apr 2021 08:37:45 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FFd7Y1PDHz4gKy; Wed, 7 Apr 2021 08:37:44 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 1378bUdG040717 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 7 Apr 2021 11:37:33 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 1378bUdG040717 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 1378bU4R040716; Wed, 7 Apr 2021 11:37:30 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 7 Apr 2021 11:37:30 +0300 From: Konstantin Belousov To: Antoine Brodin Cc: Jung-uk Kim , Konstantin Belousov , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: d36d68161517 - main - rtld dl_iterate_phdr(): dlpi_tls_data is wrong Message-ID: References: <202104060037.1360bKwT029051@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=0.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM,FREEMAIL_REPLY, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4FFd7Y1PDHz4gKy X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Apr 2021 08:37:45 -0000 On Wed, Apr 07, 2021 at 10:19:51AM +0200, Antoine Brodin wrote: > On Tue, Apr 6, 2021 at 8:36 PM Jung-uk Kim wrote: > > > > On 21. 4. 5., Konstantin Belousov wrote: > > > The branch main has been updated by kib: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=d36d6816151705907393889d661cbfd25c630ca8 > > > > > > commit d36d6816151705907393889d661cbfd25c630ca8 > > > Author: Konstantin Belousov > > > AuthorDate: 2021-04-05 03:05:44 +0000 > > > Commit: Konstantin Belousov > > > CommitDate: 2021-04-06 00:23:08 +0000 > > > > > > rtld dl_iterate_phdr(): dlpi_tls_data is wrong > > > > > > dl_iterate_phdr() dlpi_tls_data should provide the TLS module segment > > > address, and not the TLS init segment address as it does now. > > > > > > Reported by: emacsray@gmail.com > > > PR: 254774 > > > Sponsored by: The FreeBSD Foundation > > > MFC after: 1 week > > > > I started having strange hangs in various applications from yesterday, > > e.g., Xorg, Thunderbird, etc. Today, I updated ports tree from Git for > > the first time and started updating packages. Then, I experienced > > similar problems, e.g., building editors/kate, multimedia/vlc, etc., > > were hanging. I noticed some tools were stuck in urwlck state and I > > found reverting this commit fixed the problem for me. > > > > Please take a look. > > Hi, > > I don't know if it's related, but some port builds are hanging with > b8028f9d3ca0 that didn't happen with 4c2e9c35fb19. Perhaps this is related. I did not received the backtrace from the hung process to say definitely. The D29623 review is the fix.