Date: Sun, 29 Jul 2007 21:57:29 GMT From: "Herbert J. Skuhra" <h.skuhra@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/115021: [PATCH] audio/gtkpod: add missing dependencies for vorbis & flac Message-ID: <200707292157.l6TLvTrn016381@www.freebsd.org> Resent-Message-ID: <200707292200.l6TM06YI089635@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 115021 >Category: ports >Synopsis: [PATCH] audio/gtkpod: add missing dependencies for vorbis & flac >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Jul 29 22:00:05 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Herbert J. Skuhra >Release: FreeBSD 6.2-STABLE i386 >Organization: >Environment: FreeBSD oslo.ath.cx 6.2-STABLE FreeBSD 6.2-STABLE #0: Sat Jul 14 10:15:17 CEST 2007 herbert@oslo.ath.cx:/usr/obj/usr/src/sys/PC1 i386 >Description: The port audio/gtkpod is build with ogg and flac support when libvorbis and libFLAC is detected during configure. There is no LIB_DEPENDS for both. >How-To-Repeat: >Fix: The attached patch* adds two knobs (VORBIS & FLAC) and the required dependencies. * http://norway.ath.cx/freebsd/gtkpod_20070729.diff Patch attached with submission follows: --- Makefile.bak 2007-07-29 23:40:10.000000000 +0200 +++ Makefile 2007-07-29 23:43:14.000000000 +0200 @@ -7,6 +7,7 @@ PORTNAME= gtkpod PORTVERSION= 0.99.10 +PORTREVISION= 1 CATEGORIES= audio MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} MASTER_SITE_SUBDIR= ${PORTNAME} @@ -25,7 +26,9 @@ GNU_CONFIGURE= yes INSTALLS_ICONS= yes -OPTIONS= MPEG4IP "Enable AAC and H.264 support with MPEG4IP" off +OPTIONS= MPEG4IP "Enable AAC and H.264 support with MPEG4IP" off \ + VORBIS "Enable OGG support" off \ + FLAC "Enable FLAC support" off .include <bsd.port.pre.mk> @@ -33,10 +36,26 @@ WITH_MPEG4IP= YES .endif +.if exists(${LOCALBASE}/lib/libvorbis.so) +WITH_VORBIS= YES +.endif + +.if exists(${LOCALBASE}/lib/libFLAC.so) +WITH_FLAC= YES +.endif + .if defined(WITH_MPEG4IP) LIB_DEPENDS+= mp4v2.0:${PORTSDIR}/multimedia/mpeg4ip-libmp4v2 .endif +.if defined(WITH_VORBIS) +LIB_DEPENDS+= vorbis.4:${PORTSDIR}/audio/libvorbis +.endif + +.if defined(WITH_FLAC) +LIB_DEPENDS+= FLAC.7:${PORTSDIR}/audio/flac +.endif + CONFIGURE_ENV+= CPPFLAGS="-I${LOCALBASE}/include" CONFIGURE_ENV+= LDFLAGS="-L${LOCALBASE}/lib" >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200707292157.l6TLvTrn016381>