From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Feb 6 07:14:33 2004 Return-Path: Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A409F16A4CE; Fri, 6 Feb 2004 07:14:33 -0800 (PST) Received: from mail.droso.net (koala.droso.net [193.162.142.74]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5FAE743D48; Fri, 6 Feb 2004 07:14:31 -0800 (PST) (envelope-from erwin@mail.droso.net) Received: by mail.droso.net (Postfix, from userid 1001) id 8B47A22866; Fri, 6 Feb 2004 16:14:28 +0100 (CET) Date: Fri, 6 Feb 2004 16:14:28 +0100 From: Erwin Lansing To: Mathieu Arnold Message-ID: <20040206151428.GA5722@droso.net> Mail-Followup-To: Mathieu Arnold , Lars Thegler , freebsd-ports-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org References: <200402060949.i169nUt9039804@freefall.freebsd.org> <40239C5D.2050603@thegler.dk> <336299453.1076082424@andromede.faubourg.reaumur.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="W/nzBZO5zC0uMSeA" Content-Disposition: inline In-Reply-To: <336299453.1076082424@andromede.faubourg.reaumur.net> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD/i386 5.2-RELEASE-p2 cc: freebsd-ports-bugs@FreeBSD.org cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: ports/62398: [PATCH] devel/p5-AppConfig: update to 1.56, take maintainership X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Feb 2004 15:14:33 -0000 --W/nzBZO5zC0uMSeA Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 06, 2004 at 03:47:04PM +0100, Mathieu Arnold wrote: > +-le 06/02/2004 14:53 +0100, Lars Thegler =E9crivait : > | Erwin Lansing wrote: > |> Should Test::Simple be added as a dependencies or are you sure > |> it is only used by make test? > |=20 > | Yes, Test::More is only used for testing. But I get your point - to sil= ence > | the warning, either the dependency should be added, or the Makefile.PL > | patched. What's best practice in these cases? >=20 > As far as I can tell, there are good chances that Test::Simple is already > installed, but I would not bring a SOMETHING_DEPENDS if it does not really > depends on it. if a developper wants to make test, he's likely to have it > already, and if not, he's likely to be smart enough to find out how to ad= d it. > All this to say that I don't think adding a dependency just to shut up > Makefile.PL is a good thing. >=20 I replied to Lars personally, but let me repeat it here. I have seen both cases, where the maintainer adds Test::Simple or just leaves the warning. Personally I add the dependency as I assume (most likely wrongly in several cases) that if the author tests for it, it needs it. But I'll leave it up to the maintainers discression to decide. -erwin --=20 _._ _,-'""`-._ Erwin Lansing (,-.`._,'( |\`-/| erwin@lansing.dk http://droso.org `-.-' \ )-`( , o o) erwin@FreeBSD.org -bf- `- \`_`"'- --W/nzBZO5zC0uMSeA Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAI69Uqy9aWxUlaZARAsQbAKDfIAB+H97x6YEWdZ66wJmrd9GJ3gCg72Or nbOanXRsJzyuvS0+yCPMmnY= =8y3F -----END PGP SIGNATURE----- --W/nzBZO5zC0uMSeA--