From owner-freebsd-net@FreeBSD.ORG Thu Dec 18 11:08:56 2014 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2ED178B4; Thu, 18 Dec 2014 11:08:56 +0000 (UTC) Received: from venus.codepro.be (venus.codepro.be [IPv6:2a01:4f8:162:1127::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.codepro.be", Issuer "Gandi Standard SSL CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DD29910B7; Thu, 18 Dec 2014 11:08:55 +0000 (UTC) Received: from vega.codepro.be (unknown [172.16.1.3]) by venus.codepro.be (Postfix) with ESMTP id 3B3C521DA3; Thu, 18 Dec 2014 12:08:51 +0100 (CET) Received: by vega.codepro.be (Postfix, from userid 1001) id 3126A10224; Thu, 18 Dec 2014 12:08:51 +0100 (CET) Date: Thu, 18 Dec 2014 12:08:51 +0100 From: Kristof Provost To: Ilya Bakulin Subject: Re: PF IPv6 fragments handling (was: Re: Checksumming outgoing packets in PF vs in ip[6]_output) Message-ID: <20141218110850.GR5741@vega.codepro.be> References: <1415210423.3394438.187470637.21CD8D3D@webmail.messagingengine.com> <9355b23f1a07008eca61f16ebd828d0b@mail.bakulin.de> <20141107133101.GF2044@vega.codepro.be> <545F6C8F.6010700@bakulin.de> <20141109201557.GH2044@vega.codepro.be> <694672ef2ebe8adb6badcd4b059942c1@mail.bakulin.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <694672ef2ebe8adb6badcd4b059942c1@mail.bakulin.de> X-PGP-Fingerprint: E114 D9EA 909E D469 8F57 17A5 7D15 91C6 9EFA F286 X-Checked-By-NSA: Probably User-Agent: Mutt/1.5.23 (2014-03-12) Cc: freebsd-net@freebsd.org, Jim Thompson , clusteradm@freebsd.org, Mark Felder , freebsd-pf@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Dec 2014 11:08:56 -0000 On 2014-12-18 11:29:01 (+0100), Ilya Bakulin wrote: > On 2014-11-09 21:15, Kristof Provost wrote: > > On 2014-11-09 14:30:55 (+0100), Ilya Bakulin wrote: > >> On 07.11.14, 14:31, Kristof Provost wrote: > > You can find the patch series here: > > http://www.sigsegv.be/files/pf_inet6_frag.tar > > and everything in one big patch here: > > http://www.sigsegv.be/files/pf_inet6_frag.patch > > > > I have tested your patchset and it works! > At this poing I would like to ask clusteradm@ (CC'ed) to at least look > at this patchet. The distinction between CROP and DROP that was dropped > upstream is IMHO not important :-) I highly doubt that it makes any > difference to anyone, and parcticularly at FreeBSD cluster. On the other > hand, Thanks for testing! I still have the CROP/DROP thing on my TODO. If there's a consensus that we can drop it that's fine by me of course. In that case I'll just clean up the current patches and submit those for review. If people feel we should keep CROP/DROP (as was my original plan) I should have some time to work on that over the holidays. Regards, Kristof