From nobody Thu Mar 7 11:25:07 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tr6RP72rCz5CpC8; Thu, 7 Mar 2024 11:25:21 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tr6RP4GLmz4fyJ; Thu, 7 Mar 2024 11:25:21 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-5132181d54bso833924e87.3; Thu, 07 Mar 2024 03:25:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709810720; x=1710415520; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3dppH9jJpNRnEIH8NYT9Lm5VXN9KhOvzEynE6btRWYI=; b=RUnrWZfERaRm/nDReGck3hGj4Ks/CxI6TL1qU7LXTCafH2CWcF1rBhdxFisU8gW3TG XIHK/McQ3dDtnvGIPJcXiKWTrzz1yvIo0XWg2VX6QG5/hPtrdLojzoAr+3AnQmMNB6ob dEQWTNssB8grz5J9o+N3wSTeFLWGgiHyR88xHab1ne6GMm/JGTBwi0U5PIBxNUz5Kw8i mVdkib1PVGxdf1ImwlP2QVBM5fpe2lLWKD0XLZ1tgzJd2+zfoSRDtV9UWMWPHBN5o9QC g+jz6RUyvHf8VxWqeQQ4LUQXD9s3Ec82RsCu3KiNN70yMdWNThEWHerL3IdhLDQrcHf9 BLig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709810720; x=1710415520; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3dppH9jJpNRnEIH8NYT9Lm5VXN9KhOvzEynE6btRWYI=; b=P4RcTeMhFp4fyLOcONE7DtI2iYsQvGdNCOarb3qLhJ9bV+QrxFwbDMG+XLxvt0C6Hx QPSAhDkRT54iVFm1ihKb6YBRqgx5mde31VKvz3ChMPzjOq+odXx85zXKHD99ZSzmyeJQ tEmSH0zHci1hFhSUtZoIYweheXQMTjvjp0EAPxiVD5DKbcBpy7BflgU2WafsZAdPDm2w 9t6eX61GVoYBe+8GncgIBclhG3p8Knpy5EvQroDTYReH7w/2sT141NKifQPP/DbMd4dm QpxzZOSv+nyOWaxn1OtW+CQffdogjHEdtoUKskYfNxa2Rvqf2tY2kJNov+3Cv6AeSgCF 8t/Q== X-Forwarded-Encrypted: i=1; AJvYcCX1u6Bs593uRF4hly84cWQ2sXUx5SlW00cmYiJmteyJaZlrO+7BsJd8GYukdQnpnz+WOny42MfV9eCCfE8NCQg33fKUNC6f5tyXBPt5mVjikptx9g48HGS17JToMclwtk48TvuHR00xu+sWUL47Ra2umwUyfo5yIBYHPiYkP2wLgg7/DZM/ear0OuWDL62lAqsRLm70Rp5j0gyiVv8UPrUVPY9vHnZ5xg== X-Gm-Message-State: AOJu0Yw56vCmApdZweiFszEafsqPEGpO/AJlbzhLaxgd5WzijrJGhsg3 JxsM4STjyEc25R9FPaHvoAF5Q+QzCnEhdemuOIrKUyfZF6AKElj1xK/0zmu31NdI9Ib+E2DvtqU igQlUgolIE+fhuAYFEAQfQl7dE8CBjRvzIYjEtw== X-Google-Smtp-Source: AGHT+IEVsv2aERZDwxM7mHbf+7mthowQc2tHVaoq2Wms5v0HLxn7KIQasNtK5K3tkpHupgBPW4wX2wfCI5bMwLTdOsI= X-Received: by 2002:a05:6512:708:b0:513:1561:af08 with SMTP id b8-20020a056512070800b005131561af08mr1012753lfs.60.1709810719703; Thu, 07 Mar 2024 03:25:19 -0800 (PST) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202403031936.423JaMcm054153@gitrepo.freebsd.org> <0d76f19c6d2e3e2b70a2ccc07c71e1ce@mail.infomaniak.com> In-Reply-To: From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Thu, 7 Mar 2024 12:25:07 +0100 Message-ID: Subject: Re: git: ea45a9a53499 - main - cad/PrusaSlicer: Mark BROKEN To: =?UTF-8?Q?Lo=C3=AFc_Bartoletti?= Cc: Daniel Engberg , Daniel Engberg , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000094cd15061310548a" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4Tr6RP4GLmz4fyJ --00000000000094cd15061310548a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 7, 2024 at 7:54=E2=80=AFAM Lo=C3=AFc Bartoletti wrote: > Hi, > > I haven't looked at exactly what the problem is here, but just in case, > you should know that CGAL is header only (well, you still need to > install boost), but that you can very well use the correct version of > CGAL (e.g. 5.6.0) if it's not in the ports; that's what I do for > databases/sfcgal > Yes, I know. That is one of the "problems". Installing header files rarely fails. It is when consumers include those headers when the problems arise. In this case though, it seems that math/cgal has a test suite (according to the CMakeLists.txt) That test suite, if enabled, should detect the issue. On the other hand, with a quick test, latest math/cgal (5.6.1) also makes cad/PrusaSlicer build fail with a different error: /wrkdirs/usr/ports/cad/PrusaSlicer/work/PrusaSlicer-version_2.6.0/src/libsl= ic3r/MeshBoolean.cpp:151:16: error: non-const lvalue reference to type 'reference' (aka 'CGAL::SM_Vertex_index') cannot bind to a temporary of type 'reference' (aka 'CGAL::SM_Vertex_index') for (auto &vi : vertices) { ^ ~ /wrkdirs/usr/ports/cad/PrusaSlicer/work/PrusaSlicer-version_2.6.0/src/libsl= ic3r/MeshBoolean.cpp:185:25: note: in instantiation of function template specialization 'Slic3r::MeshBoolean::cgal::cgal_to_indexed_triangle_set>>' requested here return TriangleMesh{cgal_to_indexed_triangle_set(cgalmesh.m)}; ^ /usr/local/include/CGAL/Iterator_range.h:49:5: note: selected 'begin' function with iterator type 'CGAL::Surface_mesh>::Index_iterator' I begin() const ^ /wrkdirs/usr/ports/cad/PrusaSlicer/work/PrusaSlicer-version_2.6.0/src/libsl= ic3r/MeshBoolean.cpp:156:16: error: non-const lvalue reference to type 'reference' (aka 'CGAL::SM_Face_index') cannot bind to a temporary of type 'reference' (aka 'CGAL::SM_Face_index') for (auto &face : faces) { ^ ~ /usr/local/include/CGAL/Iterator_range.h:49:5: note: selected 'begin' function with iterator type 'CGAL::Surface_mesh>::Index_iterator' I begin() const ^ Cheers > > All the best, > > Lo=C3=AFc > > Le 06/03/2024 =C3=A0 22:34, Daniel Engberg a =C3=A9crit : > > On 2024-03-04T18:34:16.000+01:00, Fernando Apestegu=C3=ADa < > fernando.apesteguia@gmail.com> wrote: > >> On Sun, Mar 3, 2024 at 8:36=E2=80=AFPM Daniel Engberg > wrote: > >> > >> > >>> The branch main has been updated by diizzy: > >>> > >>> URL: > >>> > https://cgit.FreeBSD.org/ports/commit/?id=3Dea45a9a534994a1bf97a162168902= cebbca1f4c1 > >>> > >>> commit ea45a9a534994a1bf97a162168902cebbca1f4c1 > >>> Author: Daniel Engberg > >>> AuthorDate: 2024-03-03 08:29:04 +0000 > >>> Commit: Daniel Engberg > >>> CommitDate: 2024-03-03 19:26:10 +0000 > >>> > >>> cad/PrusaSlicer: Mark BROKEN > >>> > >>> Fails to build, error: no member named 'prior' in namespace > 'boost' > >>> > >>> Reported by: pkg-fallout > >>> --- > >>> cad/PrusaSlicer/Makefile | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>> diff --git a/cad/PrusaSlicer/Makefile b/cad/PrusaSlicer/Makefile > >>> index dc125244df20..936e76216daf 100644 > >>> --- a/cad/PrusaSlicer/Makefile > >>> +++ b/cad/PrusaSlicer/Makefile > >>> @@ -12,6 +12,8 @@ WWW=3D https://www.prusa3d.com/prusaslic= er/ > >>> LICENSE=3D AGPLv3 > >>> LICENSE_FILE=3D ${WRKSRC}/LICENSE > >>> > >>> +BROKEN=3D fails to build, error: no member named > 'prior' in > >>> namespace 'boost' > >>> + > >>> > >> > >> Can we revert this? > >> It is an issue with math/cgal and not cad/PrusaSlicer ( > >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277480) > >> > >> Cheers. > >> > >> > >> > >>> BUILD_DEPENDS=3D cereal>=3D1.3.0.10:devel/cereal \ > >>> cgal>=3D5.0.2:math/cgal \ > >>> opencascade>=3D7.7.0:cad/opencascade > > Hi, > > > > It breaks Prusaslicer either way? > > > https://pdr2.bofh.network/data/140-diizzy/2024-03-02_16h50m15s/logs/error= s/PrusaSlicer-2.6.0_8.log > > > > Best regards, > > Daniel > --00000000000094cd15061310548a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Mar 7, 2024 at 7:54=E2=80=AFA= M Lo=C3=AFc Bartoletti <lba= rtoletti@tuxfamily.org> wrote:
Hi,

I haven't looked at exactly what the problem is here, but just in case,=
you should know that CGAL is header only (well, you still need to
install boost), but that you can very well use the correct version of
CGAL (e.g. 5.6.0) if it's not in the ports; that's what I do for databases/sfcgal

Yes, I know. That is o= ne of the "problems".
Installing header files rarely fa= ils.
It is when consumers include those headers when the problems= arise.
In this case though, it seems that math/cgal has a test s= uite (according to the CMakeLists.txt)
That test suite, if enable= d, should detect the issue.

On the other hand, wit= h a quick test, latest math/cgal (5.6.1) also makes cad/PrusaSlicer build f= ail with a different error:

/wrkdirs/usr/ports/cad= /PrusaSlicer/work/PrusaSlicer-version_2.6.0/src/libslic3r/MeshBoolean.cpp:1= 51:16: error: non-const lvalue reference to type 'reference' (aka &= #39;CGAL::SM_Vertex_index') cannot bind to a temporary of type 'ref= erence' (aka 'CGAL::SM_Vertex_index')
=C2=A0 =C2=A0 for (aut= o &vi : vertices) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0^ =C2=A0~
/wrkdirs/usr/ports/cad/PrusaSlicer/work/PrusaSlicer-ver= sion_2.6.0/src/libslic3r/MeshBoolean.cpp:185:25: note: in instantiation of = function template specialization 'Slic3r::MeshBoolean::cgal::cgal_to_in= dexed_triangle_set<CGAL::Surface_mesh<CGAL::Point_3<CGAL::Epick>= ;>>' requested here
=C2=A0 =C2=A0 return TriangleMesh{cgal_to_= indexed_triangle_set(cgalmesh.m)};
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^
/usr/local/include/CG= AL/Iterator_range.h:49:5: note: selected 'begin' function with iter= ator type 'CGAL::Surface_mesh<CGAL::Point_3<CGAL::Epick>>::= Index_iterator<CGAL::SM_Vertex_index>'
=C2=A0 I begin() const<= br>=C2=A0 =C2=A0 ^
/wrkdirs/usr/ports/cad/PrusaSlicer/work/PrusaSlicer-v= ersion_2.6.0/src/libslic3r/MeshBoolean.cpp:156:16: error: non-const lvalue = reference to type 'reference' (aka 'CGAL::SM_Face_index') c= annot bind to a temporary of type 'reference' (aka 'CGAL::SM_Fa= ce_index')
=C2=A0 =C2=A0 for (auto &face : faces) {
=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^ =C2=A0 =C2=A0~
/usr/lo= cal/include/CGAL/Iterator_range.h:49:5: note: selected 'begin' func= tion with iterator type 'CGAL::Surface_mesh<CGAL::Point_3<CGAL::E= pick>>::Index_iterator<CGAL::SM_Face_index>'
=C2=A0 I be= gin() const
=C2=A0 =C2=A0 ^

Cheers
=C2=A0

All the best,

Lo=C3=AFc

Le 06/03/2024 =C3=A0 22:34, Daniel Engberg a =C3=A9crit=C2=A0:
> On 2024-03-04T18:34:16.000+01:00, Fernando Apestegu=C3=ADa <fernando.apeste= guia@gmail.com> wrote:
>>=C2=A0 =C2=A0On Sun, Mar 3, 2024 at 8:36=E2=80=AFPM Daniel Engberg = <diizzy@freebsd.= org> wrote:
>>
>>
>>>=C2=A0 =C2=A0 =C2=A0The branch main has been updated by diizzy:=
>>>
>>>=C2=A0 =C2=A0URL:
>>>=C2=A0 =C2=A0https://cgit.FreeBSD.org/ports/commit/?id=3Dea45a9a534994a1bf97a16= 2168902cebbca1f4c1
>>>
>>>=C2=A0 =C2=A0commit ea45a9a534994a1bf97a162168902cebbca1f4c1 >>>=C2=A0 =C2=A0Author:=C2=A0 =C2=A0 =C2=A0Daniel Engberg <diiz= zy@FreeBSD.org>
>>>=C2=A0 =C2=A0AuthorDate: 2024-03-03 08:29:04 +0000
>>>=C2=A0 =C2=A0Commit:=C2=A0 =C2=A0 =C2=A0Daniel Engberg <diiz= zy@FreeBSD.org>
>>>=C2=A0 =C2=A0CommitDate: 2024-03-03 19:26:10 +0000
>>>
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0cad/PrusaSlicer: Mark BROKEN
>>>
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0Fails to build, error: no member nam= ed 'prior' in namespace 'boost'
>>>
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0Reported by:=C2=A0 =C2=A0 pkg-fallou= t
>>>=C2=A0 =C2=A0---
>>>=C2=A0 =C2=A0 cad/PrusaSlicer/Makefile | 2 ++
>>>=C2=A0 =C2=A0 1 file changed, 2 insertions(+)
>>>
>>>=C2=A0 =C2=A0diff --git a/cad/PrusaSlicer/Makefile b/cad/PrusaS= licer/Makefile
>>>=C2=A0 =C2=A0index dc125244df20..936e76216daf 100644
>>>=C2=A0 =C2=A0--- a/cad/PrusaSlicer/Makefile
>>>=C2=A0 =C2=A0+++ b/cad/PrusaSlicer/Makefile
>>>=C2=A0 =C2=A0@@ -12,6 +12,8 @@ WWW=3D=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 https://www.prusa3d.com/prusaslicer/
>>>=C2=A0 =C2=A0 LICENSE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0AGPLv3
>>>=C2=A0 =C2=A0 LICENSE_FILE=3D=C2=A0 ${WRKSRC}/LICENSE
>>>
>>>=C2=A0 =C2=A0+BROKEN=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 fails to build, error: no member named 'prior' in=
>>>=C2=A0 =C2=A0namespace 'boost'
>>>=C2=A0 =C2=A0+
>>>
>>=C2=A0 =C2=A0
>> Can we revert this?
>> It is an issue with math/cgal and not cad/PrusaSlicer (
>> https://bugs.freebsd.org/bugzilla= /show_bug.cgi?id=3D277480)
>>
>> Cheers.
>>
>>
>>
>>>=C2=A0 =C2=A0 =C2=A0 BUILD_DEPENDS=3D cereal&gt;=3D1.3.0.10= :devel/cereal \
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0cgal&gt;=3D5.0.2:math/cgal \
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0opencascade&gt;=3D7.7.0:cad/opencascade
> Hi,
>
> It breaks Prusaslicer either way?
> https://pdr2.bofh.network/data/140-diizzy/2024-03-02_16h50m15s/logs/erro= rs/PrusaSlicer-2.6.0_8.log
>
> Best regards,
> Daniel
--00000000000094cd15061310548a--