From owner-svn-src-all@FreeBSD.ORG Wed Jul 17 06:03:12 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id DFBE258C; Wed, 17 Jul 2013 06:03:11 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-vc0-x229.google.com (mail-vc0-x229.google.com [IPv6:2607:f8b0:400c:c03::229]) by mx1.freebsd.org (Postfix) with ESMTP id 6C3737B9; Wed, 17 Jul 2013 06:03:11 +0000 (UTC) Received: by mail-vc0-f169.google.com with SMTP id ia10so1090160vcb.28 for ; Tue, 16 Jul 2013 23:03:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=46AqxyfVgGhr//K/VlUxkPXv/6fMrLtZNQGaLovSQPI=; b=sCwdyffnIULzg+xsO0vATQqEhyRz8u6j7k4nsulC44ZFGOenamrRV3jC8E3m+mXbry /rTMcoOHvcCx6HOtRNSd67OiHkqBDz+Dt3+ktxG0So7uUTyIVLm0rsPKPKDZ3J3GvtIy 2zppO5Emwu6tDwMLquL9k8fWL7dGYK/iQ15AVWFDTWTXKv3+16vObn8cAnuMyYi3I5jc kyg9zMEhB7i271ijzbeq1NXahxEPHUL7mWRuuQbqYIrAI8mq90CnVMAzQGM+E2YWrk2o 0EshUiruqLK+kK3gikgETW4RXOEvUG41qveLaqpDlRoYOhWsQwcbIlnLVb8OZmWN3neG msBw== MIME-Version: 1.0 X-Received: by 10.59.0.2 with SMTP id au2mr1543671ved.83.1374040990992; Tue, 16 Jul 2013 23:03:10 -0700 (PDT) Received: by 10.220.146.145 with HTTP; Tue, 16 Jul 2013 23:03:10 -0700 (PDT) In-Reply-To: <201307110826.44287.jhb@freebsd.org> References: <201307082125.r68LPDlY023493@svn.freebsd.org> <201307091120.22114.jhb@freebsd.org> <201307110826.44287.jhb@freebsd.org> Date: Tue, 16 Jul 2013 23:03:10 -0700 Message-ID: Subject: Re: svn commit: r253048 - in head/sys/ofed: drivers/net/mlx4 include/linux From: Garrett Cooper To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head , svn-src-all , src-committers , shahark@mellanox.com, Andrea Cornehl X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jul 2013 06:03:12 -0000 On Thu, Jul 11, 2013 at 5:26 AM, John Baldwin wrote: > On Wednesday, July 10, 2013 7:58:30 pm Garrett Cooper wrote: >> On Tue, Jul 9, 2013 at 8:20 AM, John Baldwin wrote: >> >> ... >> >> > I hadn't seen it. I had wondered if the '\n' issue was a generic sysfs thing. >> > It sounds like it is and I'd be happy to revert the mlx4 change and alter the >> > sysfs bits to manage the newline directly if that is more appropriate. >> >> I'll doublecheck this, but basically I'm really adverse to diverging >> from Linux in this area -- hence that's why I did what I did in the PR >> I mentioned. > > I checked the other sysfs attributes under sys/ofed and all the ones that deal > with strings expect the newline. There might be some that are "blobs" that do > not expect newlines, but it wasn't clear. I do agree that it would be best to > avoid diffs for this case if possible in all the sysfs handlers. > > (It would be even nicer if ofed used a more abstract notion for device attributes > in its drivers that could map to sysctl on FreeBSD and sysfs device attributes on > Linux, but that's a much larger change, and one OFED would have to want to do.) > >> > I'd also like this to use sysctl_handle_string() if at all possible. Are you in >> > a position to test patches still? >> >> Unfortunately I'm not right now :(. Anthony may or may not be able to >> test this out (I used his machine when we were hacking around on IB >> stuff). >> >> > If so, maybe give this a whirl. It's similar to yours except it uses >> > sysctl_handle_string() and strlcat() rather than continuing to do things >> > by hand. It also outputs an empty string to userland if the attribute >> > doesn't have a show method (your version would never pass out an old >> > string in that case unlike the original code). >> >> Can you please pass along a patch to Anthony and me so we can try and >> apply it to test it out (Gmail's going to taint the inline patch, as >> is the EMC Exchange server with the patch attachment)? If Anthony >> still has the machine setup, then I'd be more than happy to test out >> the patch :). > > Ok, I've put the patch at a URL. Note that it is relative to what was just > committed to HEAD, so to test on 9 you'd have to apply both patches. > > http://www.freebsd.org/~jhb/patches/ofed_sysfs.patch Sorry, but it seems that neither Anthony nor I have time to work on this... FWIW my patch might have been ok for text, but not for binary blobs (I didn't test that out before because I didn't have an easy testcase for it).