From owner-svn-ports-all@freebsd.org Sat Jul 4 08:59:02 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A0B66365FD0; Sat, 4 Jul 2020 08:59:02 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49zQjy3phWz4NWp; Sat, 4 Jul 2020 08:59:02 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from marvin.madpilot.net (host-79-53-121-114.retail.telecomitalia.it [79.53.121.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id D0BE529E5D; Sat, 4 Jul 2020 08:59:01 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Subject: Re: svn commit: r541149 - head/net/asterisk13 To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <202007032159.063LxC5m009435@repo.freebsd.org> <20200704051704.GA32566@FreeBSD.org> From: Guido Falsi Message-ID: Date: Sat, 4 Jul 2020 10:59:00 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200704051704.GA32566@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jul 2020 08:59:02 -0000 On 04/07/20 07:17, Alexey Dokuchaev wrote: > On Fri, Jul 03, 2020 at 09:59:12PM +0000, Guido Falsi wrote: >> New Revision: 541149 >> URL: https://svnweb.freebsd.org/changeset/ports/541149 >> >> Log: >> Remove SQLITE2 option. >> >> Modified: >> head/net/asterisk13/Makefile > > Commit logs should also answer the "why" question, not just translate > the diff to Enligsh. > Sorry. Actually I should have thought more about that commit message. I'll add here that sqlite2 library has been abandoned upstream since 2005. This fact was pointed out to me in the review at [1], together with the facts that the asterisk ports are the only ones actually using it. Since I agree on removal from the ports tree of obsolete software I waited for the quarterly branch and then removed the optional dependency. sqliteodbc-sqlite2 is going to exp[ire by the end of the month too. [1] https://reviews.freebsd.org/D25267 -- Guido Falsi