From owner-cvs-src@FreeBSD.ORG Mon Sep 20 18:14:16 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1739516A50F for ; Mon, 20 Sep 2004 18:14:14 +0000 (GMT) Received: from mail1.speakeasy.net (mail1.speakeasy.net [216.254.0.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id B76C043D5A for ; Mon, 20 Sep 2004 18:14:13 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 13170 invoked from network); 20 Sep 2004 18:14:13 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 20 Sep 2004 18:14:13 -0000 Received: from [10.50.40.210] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i8KIE3lV024500; Mon, 20 Sep 2004 14:14:09 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: David Schultz Date: Mon, 20 Sep 2004 13:43:53 -0400 User-Agent: KMail/1.6.2 References: <200409191834.i8JIYHXU089517@repoman.freebsd.org> In-Reply-To: <200409191834.i8JIYHXU089517@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200409201343.53529.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_proc.c kern_switch.c src/sys/sys sched.h src/sys/vm vm_glue.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Sep 2004 18:14:17 -0000 On Sunday 19 September 2004 02:34 pm, David Schultz wrote: > das 2004-09-19 18:34:17 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_proc.c kern_switch.c > sys/sys sched.h > sys/vm vm_glue.c > Log: > The zone from which proc structures are allocated is marked > UMA_ZONE_NOFREE to guarantee type stability, so proc_fini() should > never be called. Move an assertion from proc_fini() to proc_dtor() > and garbage-collect the rest of the unreachable code. I have retained > vm_proc_dispose(), since I consider its disuse a bug. Arguably the UMA_ZONE_NOFREE bit is the bug. Do we know what code assumes type stability of proc structures? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org